Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VM executes ge on value for gt instruction #1041

Closed
stephanemagnenat opened this issue Jan 5, 2021 · 1 comment · Fixed by #1044
Closed

VM executes ge on value for gt instruction #1041

stephanemagnenat opened this issue Jan 5, 2021 · 1 comment · Fixed by #1044
Labels
E-Easy Easy good first issue Good for newcomers vm Issues and PRs related to the Boa Virtual Machine.
Milestone
v0.12.0

Comments

@stephanemagnenat
Copy link
Contributor

This looks wrong:

boa/boa/src/vm/mod.rs

Line 186 in 0e41be1

let val = l.ge(&r, self.ctx)?;

because it is in the Gt branch of the match:

boa/boa/src/vm/mod.rs

Line 183 in 0e41be1

Instruction::Gt => {

@jasonwilliams jasonwilliams added E-Easy Easy good first issue Good for newcomers labels Jan 5, 2021
@stephanemagnenat stephanemagnenat mentioned this issue Jan 6, 2021
Merged
@stephanemagnenat
Copy link
Contributor Author

This is solved indirectly by #1044.

@Razican Razican added the vm Issues and PRs related to the Boa Virtual Machine. label Jan 6, 2021
@Razican Razican added this to the v0.12.0 milestone Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-Easy Easy good first issue Good for newcomers vm Issues and PRs related to the Boa Virtual Machine.
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging a pull request may close this issue.

Removed duplicated code in vm.run using macros. stephanemagnenat/boa
3 participants
@stephanemagnenat @Razican @jasonwilliams