Removed duplicated code in vm.run using macros.

[stephanemagnenat]

This Pull Request reduces code duplication in VM execution, this refactoring let me find issue #1041.

It changes the following:

• It factors out the push of the result to the stack.
• It adds a macro for binary operations.

I did not use the macro equality, in order to keep the balance with the inequality code which, due to the ! before the into, would still need the macro. When using the binop macro, one might want to put the call in a single line instead of using { ... }.

I do not know whether upstream wants this change, but I submit it just in case. I do not know if the vm feature is enabled in CI.

This PR also fixes #1041.

[codecov]

Codecov Report

Merging #1044 (4e69075) into master (9e0cab5) will increase coverage by 0.35%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1044      +/-   ##
==========================================
+ Coverage   58.53%   58.88%   +0.35%     
==========================================
  Files         176      172       -4     
  Lines       12547    11709     -838     
==========================================
- Hits         7344     6895     -449     
+ Misses       5203     4814     -389     

Impacted Files	Coverage Δ
boa/src/vm/mod.rs	0.00% <0.00%> (ø)
boa/src/syntax/lexer/string.rs	38.09% <0.00%> (-26.32%)	⬇️
boa/src/builtins/boolean/mod.rs	30.00% <0.00%> (-13.91%)	⬇️
boa/src/builtins/error/uri.rs	65.00% <0.00%> (-5.00%)	⬇️
boa/src/builtins/error/eval.rs	65.00% <0.00%> (-5.00%)	⬇️
boa/src/builtins/error/type.rs	65.00% <0.00%> (-5.00%)	⬇️
boa/src/builtins/error/range.rs	65.00% <0.00%> (-5.00%)	⬇️
boa/src/builtins/error/syntax.rs	65.00% <0.00%> (-5.00%)	⬇️
boa/src/builtins/error/reference.rs	65.00% <0.00%> (-5.00%)	⬇️
boa/src/value/conversions.rs	59.01% <0.00%> (-3.28%)	⬇️
... and 54 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e5dca...6af409e. Read the comment docs.

[jasonwilliams]

@stephanemagnenat sorry for the conflict, we have a few PRs in this area at the moment

[stephanemagnenat]

Do you want me to fix the conflict (by using an optional result), or is there a lot ongoing and I should rather wait that the new code is completed?

[jasonwilliams]

@stephanemagnenat you’re free to carry on now it all went in

[stephanemagnenat]

I've rebased my changes on master.

[stephanemagnenat]

I was not fully sure for the naming of the macro, between binop (currently), and bin_op, the current one making vscode's spellchecking complain.

[RageKnify]

I was not fully sure for the naming of the macro, between binop (currently), and bin_op, the current one making vscode's spellchecking complain.

I agree with code, bin_op makes it easier to read as two separate words, I'd also suggest changing the name of the macro's argument from $e to $op as in operation.

[stephanemagnenat]

Done!

[jasonwilliams]

Looks good!

[jasonwilliams]

Thanks for the contribution @stephanemagnenat !

[jasonwilliams]

I do not know if the vm feature is enabled in CI.

No it isn't currently but we hope to change that some point in the future