Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CLI to use Clap 3.0 #1955

Closed
Razican opened this issue Mar 18, 2022 · 2 comments
Closed

Update CLI to use Clap 3.0 #1955

Razican opened this issue Mar 18, 2022 · 2 comments
Assignees
@manthanabc
Labels
cli Issues and PRs related to the Boa command line interface. E-Easy Easy enhancement New feature or request good first issue Good for newcomers
Milestone
v0.15.0

Comments

@Razican
Copy link
Member

Razican commented Mar 18, 2022

We currently use structopt for our CLI, but now that Clap has released its 3.0 version, the functionality has improved to the point where structopt is no longer needed: https://crates.io/crates/clap

We would like to move from using structopt to using clap.
@Razican Razican added enhancement New feature or request cli Issues and PRs related to the Boa command line interface. labels Mar 18, 2022
@Razican Razican added this to the v0.15.0 milestone Mar 18, 2022
@Razican Razican added the good first issue Good for newcomers label Mar 18, 2022
@jasonwilliams jasonwilliams added the E-Easy Easy label Mar 18, 2022
@manthanabc
Copy link
Contributor

Can i give it a try?

@Razican
Copy link
Member Author

Razican commented Mar 18, 2022

I assigned it to you :) let us know if you'd want some help!

@manthanabc manthanabc mentioned this issue Mar 19, 2022
Closed
@bors bors bot closed this as completed in 5fa1668 Mar 20, 2022
Razican pushed a commit that referenced this issue Jun 8, 2022
@manthanabc @Razican
migrated to clap 3 (#1957)
afb4343 
This Pull Request fixes/closes #1955.

It changes the following:

- changes structopt to clap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manthanabc manthanabc

Labels
cli Issues and PRs related to the Boa command line interface. E-Easy Easy enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - migrated to clap 3 manthanabc/boa
3 participants
@Razican @jasonwilliams @manthanabc