Remove calls to the mk macro on final returns in parser.rs #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This urges a discussion:
What do the
Position
attributes do in theExpr
structs? They don't have a use currently, but I can't imagine they were thrown in there by Bebbington "just because".The solution proposed is probably more of a band-aid than an actual solution. At least until we can figure out what the
start
andend
(Position
) attrs are for.