Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clippy erorrs #1015

Merged
merged 3 commits into from
Dec 31, 2020
Merged

Fix Clippy erorrs #1015

merged 3 commits into from
Dec 31, 2020

Conversation

AnnikaCodes
Copy link
Contributor

@AnnikaCodes AnnikaCodes commented Dec 31, 2020

This PR changes the following:

  • Fixes Clippy errors (based on cargo clippy -Z unstable-options --fix)
    • if we want to turn off the range.contains() thing that's okay too
  • Ignores the unnecessary_wraps Clippy lint; it looks like we want all NativeFunctions to return a Result, which entails "unnecessary" wrapping. turns out this is just a Nightly Rust thing

@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

Merging #1015 (05f6002) into master (23bc476) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1015      +/-   ##
==========================================
+ Coverage   59.79%   59.82%   +0.03%     
==========================================
  Files         167      167              
  Lines       11087    11085       -2     
==========================================
+ Hits         6629     6632       +3     
+ Misses       4458     4453       -5     
Impacted Files Coverage Δ
boa/src/builtins/bigint/mod.rs 71.64% <100.00%> (+1.49%) ⬆️
boa/src/builtins/date/mod.rs 67.87% <100.00%> (ø)
boa/src/builtins/number/mod.rs 63.11% <100.00%> (ø)
boa/src/object/mod.rs 51.97% <100.00%> (+0.56%) ⬆️
boa/src/syntax/lexer/cursor.rs 68.96% <100.00%> (+0.67%) ⬆️
boa/src/syntax/lexer/mod.rs 66.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23bc476...05f6002. Read the comment docs.

@HalidOdat HalidOdat merged commit aac39cd into boa-dev:master Dec 31, 2020
@Razican Razican added this to the v0.11.0 milestone Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants