-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrap the regress error for now #1027
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1027 +/- ##
==========================================
- Coverage 60.27% 58.73% -1.54%
==========================================
Files 169 172 +3
Lines 11415 11732 +317
==========================================
+ Hits 6880 6891 +11
- Misses 4535 4841 +306
Continue to review full report at Codecov.
|
Looking good! Test262 conformance changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I would just remove the check for a Syntax error in the test, in order to avoid changing it when we fix regress.
boa/src/builtins/regexp/tests.rs
Outdated
fn no_panic_on_invalid_character_escape() { | ||
let mut context = Context::new(); | ||
|
||
assert_eq!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just try to run it, without checking that it creates a Syntax error, since that will change in the future once we fix regress. If it panics, the test will fail, if it doesn't, it will pass.
This is linked to #817. |
Regress panics on "Invalid character escape"s.
However on V8 and other JS engines these seem to be acceptable.
was causing issues in Boa, due to regress panicing and us not catching.
This PR now changes it to a SyntaxError, however this is a temporary fix, ideally it should be accepted.
Raised upstream:
ridiculousfish/regress#26