-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add receiver parameter to object internal methods #1042
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1042 +/- ##
==========================================
- Coverage 58.61% 58.56% -0.06%
==========================================
Files 172 172
Lines 11763 11920 +157
==========================================
+ Hits 6895 6981 +86
- Misses 4868 4939 +71
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minor things, conformance looks good:
Test262 conformance changes:
Test result | master count | PR count | difference |
---|---|---|---|
Total | 78,493 | 78,493 | 0 |
Passed | 24,005 | 24,308 | +303 |
Ignored | 15,585 | 15,585 | 0 |
Failed | 38,903 | 38,600 | -303 |
Panics | 90 | 90 | 0 |
Conformance | 30.58 | 30.97 | +0.39% |
I'm confused, GH won't let me request reviews from @HalidOdat and @Razican so I'l tag you instead... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good for me! Check the review by @RageKnify. I just had a small question.
This Pull Request fixes #1040.
It changes the following:
receiver
parameter[[Get]]
and[[Set]]
Array
more compliant by using[DefineOwnProperty]]
instead of[[Set]]
to define new indexed propertiesArray
specific[[DefineOwnProperty]]
[[SetPrototypeOf]]
(with cycle detection)name
andlength
of functions writable