-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add primitive promotion for method calls on GetField #1085
Conversation
property accessors were done in #987
Test262 conformance changes:
|
Codecov Report
@@ Coverage Diff @@
## master #1085 +/- ##
==========================================
- Coverage 58.70% 58.68% -0.02%
==========================================
Files 176 176
Lines 12391 12407 +16
==========================================
+ Hits 7274 7281 +7
- Misses 5117 5126 +9
Continue to review full report at Codecov.
|
Benchmark for 27a4220Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
It changes the following:
GetField
is used