-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix of instructions.rs comment, to_precision impl and rfc changes #1135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but I think it'd be nice to have 1 or 2 test cases for the change you did to round_to_precision
to make sure no regressions are introduced in the future. Is it easy to do that @NathanRoyer?
test262 numbers actually look bad Test262 conformance changes:
|
This would need a rebase in order for the build to pass. |
@NathanRoyer this directory has the test262 tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest changing a couple of things. The code looks good, but as @RageKnify mentions, you should see why there are 2 new tests failing.
Also, it needs a rebase, again.
Latest test262 results: Test262 conformance changes:
It doesn't post the comment but you can find the text in the Update Comment section of test262 results: https://github.com/boa-dev/boa/pull/1135/checks?check_run_id=2649202840 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmarks look pretty good, and conformance too. It's good to merge from my side :) thank you!
This Pull Request fixes/closes #1038.
It changes the following:
applying the changes of RFC 2700