-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix display for nodes #1312
Fix display for nodes #1312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these contributions!! This will look much better now. Could we add some tests to make sure new changes don't break it?
…s been implemented yet, but I got parse errors when testing that
…pressions don't seem to be parsed correctly
Tests take a long time to write. I'm going to work on this later tonight. I put all the tests I've written so far in the |
Something that could simplify writing the tests would be to add a folder with some code snippets to test. That way, you can just load each of them in a test and compare the outputs. |
I think setting up a loader for a bunch of files would just take more time. The most time-consuming part of these tests was just setting up the testing function, and re-writing my previous tests. |
Test262 conformance changes:
Fixed tests:
|
…ethodDefinitionField)
Alright, I've finished up the tests. The world is beautiful, and everything passes, and a lot of bugs were fixed. I think I covered everything, but tarpaulin is hard to use, so I am not entirely sure that I didn't miss something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing to avoid compiler warnings the rest looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is almost ready. Great work!!! Check my comment and @RageKnify's :)
I've fixed both of those issues. Thank you for pointing those out. Also, |
This Pull Request fixes/closes #1311
This is a collection of fixes for the
fmt::Display
functions on various nodes. With this PR, you can print aStatementList
to stdout in nearly the same format as the source code.