Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement get RegExp[@@species] #1326

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Conversation

raskad
Copy link
Member

@raskad raskad commented Jun 15, 2021

This Pull Request implements part of #1304 .

It changes the following:

  • Implement get RegExp[@@species]
  • Add tests rust tests for get RegExp[@@species]

@Razican
Copy link
Member

Razican commented Jun 15, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,897 78,897 0
Passed 26,857 26,865 +8
Ignored 15,628 15,628 0
Failed 36,412 36,404 -8
Panics 0 0 0
Conformance 34.04% 34.05% +0.01%
Fixed tests:
test/built-ins/RegExp/Symbol.species/symbol-species.js [strict mode] (previously Failed)
test/built-ins/RegExp/Symbol.species/symbol-species.js (previously Failed)
test/built-ins/RegExp/Symbol.species/symbol-species-name.js [strict mode] (previously Failed)
test/built-ins/RegExp/Symbol.species/symbol-species-name.js (previously Failed)
test/built-ins/RegExp/Symbol.species/length.js [strict mode] (previously Failed)
test/built-ins/RegExp/Symbol.species/length.js (previously Failed)
test/built-ins/RegExp/Symbol.species/return-value.js [strict mode] (previously Failed)
test/built-ins/RegExp/Symbol.species/return-value.js (previously Failed)

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! This looks very good, and it passes all the official tests :)

@Razican Razican added builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request labels Jun 15, 2021
@Razican Razican added this to the v0.13.0 milestone Jun 15, 2021
Copy link
Contributor

@RageKnify RageKnify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, if you would like @raskad you could work on doing the same for other built-ins, currently no other has the species accessor implemented.

@Razican Razican merged commit 14862f8 into boa-dev:master Jun 16, 2021
@raskad raskad deleted the regexp-species branch August 14, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants