Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect Rust 1.53 #1352

Merged
merged 5 commits into from
Jun 20, 2021
Merged

Respect Rust 1.53 #1352

merged 5 commits into from
Jun 20, 2021

Conversation

RageKnify
Copy link
Contributor

A few refactors and style fixes to respect new clippy and rustfmt.

@github-actions
Copy link

Test262 conformance changes:

Test result master count PR count difference
Total 78,897 78,897 0
Passed 26,940 26,941 +1
Ignored 15,628 15,628 0
Failed 36,329 36,328 -1
Panics 1 0 -1
Conformance 34.15% 34.15% +0.00%
Fixed tests:
test/built-ins/Map/prototype/keys/returns-iterator.js (previously Panic)

@github-actions
Copy link

Benchmark for 233a3b4

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 370.1±3.65ns 360.1±8.79ns +2.78%
Arithmetic operations (Full) 280.3±2.11µs 269.4±5.49µs +4.05%
Array access (Execution) 6.5±0.14µs 6.5±0.07µs 0.00%
Array access (Full) 297.3±6.00µs 296.0±7.24µs +0.44%
Array creation (Execution) 2.8±0.06ms 3.0±0.06ms -6.67%
Array creation (Full) 3.0±0.06ms 3.3±0.08ms -9.09%
Array pop (Execution) 933.5±11.03µs 938.7±20.75µs -0.55%
Array pop (Full) 1398.9±19.98µs 1404.4±34.17µs -0.39%
Boolean Object Access (Execution) 5.4±0.07µs 5.3±0.10µs +1.89%
Boolean Object Access (Full) 284.7±5.66µs 291.7±6.43µs -2.40%
Clean js (Execution) 609.0±14.51µs 635.8±23.97µs -4.22%
Clean js (Full) 942.7±22.83µs 934.2±17.09µs +0.91%
Clean js (Parser) 39.6±0.90µs 38.3±1.19µs +3.39%
Create Realm 455.0±14.10ns 414.6±8.98ns +9.74%
Dynamic Object Property Access (Execution) 5.2±0.10µs 5.2±0.13µs 0.00%
Dynamic Object Property Access (Full) 290.5±6.43µs 291.4±7.20µs -0.31%
Expression (Parser) 7.1±0.11µs 7.0±0.09µs +1.43%
Fibonacci (Execution) 744.7±23.05µs 749.7±17.25µs -0.67%
Fibonacci (Full) 1057.9±24.10µs 1063.3±20.52µs -0.51%
For loop (Execution) 21.9±0.57µs 21.6±0.38µs +1.39%
For loop (Full) 301.2±5.50µs 303.9±6.03µs -0.89%
For loop (Parser) 19.5±0.42µs 19.4±0.28µs +0.52%
Goal Symbols (Parser) 13.7±0.23µs 13.3±0.25µs +3.01%
Hello World (Parser) 3.9±0.12µs 4.0±0.11µs -2.50%
Long file (Parser) 782.9±13.01ns 810.3±44.19ns -3.38%
Mini js (Execution) 555.4±12.92µs 570.3±6.18µs -2.61%
Mini js (Full) 865.9±13.06µs 887.2±12.64µs -2.40%
Mini js (Parser) 34.9±0.56µs 33.9±0.78µs +2.95%
Number Object Access (Execution) 4.3±0.07µs 4.1±0.09µs +4.88%
Number Object Access (Full) 291.9±4.55µs 288.1±5.80µs +1.32%
Object Creation (Execution) 4.6±0.01µs 4.3±0.10µs +6.98%
Object Creation (Full) 288.1±5.88µs 291.8±5.76µs -1.27%
RegExp (Execution) 11.7±0.27µs 11.0±0.26µs +6.36%
RegExp (Full) 298.3±5.52µs 308.3±4.76µs -3.24%
RegExp Literal (Execution) 11.8±0.09µs 11.0±0.24µs +7.27%
RegExp Literal (Full) 292.8±7.59µs 305.9±6.07µs -4.28%
RegExp Literal Creation (Execution) 10.1±0.21µs 9.5±0.20µs +6.32%
RegExp Literal Creation (Full) 286.0±6.00µs 286.4±8.38µs -0.14%
Static Object Property Access (Execution) 4.8±0.03µs 4.6±0.11µs +4.35%
Static Object Property Access (Full) 300.1±14.09µs 296.3±4.34µs +1.28%
String Object Access (Execution) 7.5±0.13µs 7.2±0.17µs +4.17%
String Object Access (Full) 292.4±7.19µs 294.6±6.54µs -0.75%
String comparison (Execution) 6.6±0.35µs 6.4±0.14µs +3.12%
String comparison (Full) 286.8±6.19µs 287.0±7.36µs -0.07%
String concatenation (Execution) 5.2±0.10µs 5.2±0.11µs 0.00%
String concatenation (Full) 281.1±8.36µs 281.8±6.24µs -0.25%
String copy (Execution) 4.1±0.06µs 3.9±0.07µs +5.13%
String copy (Full) 277.1±7.28µs 275.0±5.91µs +0.76%
Symbols (Execution) 3.4±0.07µs 3.5±0.07µs -2.86%
Symbols (Full) 272.4±5.29µs 267.0±7.91µs +2.02%

@RageKnify RageKnify merged commit 78b926e into master Jun 20, 2021
@RageKnify RageKnify deleted the style/rust1.53 branch June 20, 2021 22:32
@Razican Razican added this to the v0.13.0 milestone Aug 24, 2021
@jasonwilliams jasonwilliams mentioned this pull request Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants