Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed documentation warnings #1381

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Fixed documentation warnings #1381

merged 1 commit into from
Jun 30, 2021

Conversation

Razican
Copy link
Member

@Razican Razican commented Jun 30, 2021

This fixes 3 documentation warnings that we were having.

@Razican Razican added bug Something isn't working documentation update documentation labels Jun 30, 2021
@Razican Razican added this to the v0.13.0 milestone Jun 30, 2021
@github-actions
Copy link

Test262 conformance changes:

Test result master count PR count difference
Total 78,897 78,897 0
Passed 26,974 26,974 0
Ignored 15,616 15,616 0
Failed 36,307 36,307 0
Panics 0 0 0
Conformance 34.19% 34.19% 0.00%

@github-actions
Copy link

Benchmark for 4eaa145

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 373.5±0.48ns 375.1±0.62ns -0.43%
Arithmetic operations (Full) 282.6±0.29µs 279.4±0.59µs +1.15%
Array access (Execution) 6.6±0.03µs 6.6±0.03µs 0.00%
Array access (Full) 306.7±0.66µs 307.3±0.70µs -0.20%
Array creation (Execution) 3.1±0.00ms 3.1±0.01ms 0.00%
Array creation (Full) 3.5±0.01ms 3.4±0.00ms +2.94%
Array pop (Execution) 995.0±4.73µs 991.5±4.23µs +0.35%
Array pop (Full) 1498.1±2.09µs 1489.4±3.19µs +0.58%
Boolean Object Access (Execution) 5.4±0.02µs 5.5±0.01µs -1.82%
Boolean Object Access (Full) 299.6±0.46µs 303.3±0.67µs -1.22%
Clean js (Execution) 658.7±4.37µs 662.5±5.35µs -0.57%
Clean js (Full) 992.3±4.41µs 993.6±4.87µs -0.13%
Clean js (Parser) 41.3±0.05µs 41.2±0.05µs +0.24%
Create Realm 457.3±0.89ns 447.8±4.88ns +2.12%
Dynamic Object Property Access (Execution) 5.3±0.01µs 5.4±0.01µs -1.85%
Dynamic Object Property Access (Full) 302.7±6.11µs 302.6±0.64µs +0.03%
Expression (Parser) 7.2±0.01µs 7.3±0.05µs -1.37%
Fibonacci (Execution) 780.4±5.36µs 775.2±1.91µs +0.67%
Fibonacci (Full) 1109.7±9.53µs 1108.0±2.77µs +0.15%
For loop (Execution) 22.7±0.08µs 22.6±0.08µs +0.44%
For loop (Full) 315.8±0.52µs 316.6±1.81µs -0.25%
For loop (Parser) 19.9±0.03µs 19.9±0.02µs 0.00%
Goal Symbols (Parser) 14.4±0.02µs 14.4±0.01µs 0.00%
Hello World (Parser) 4.0±0.01µs 4.0±0.00µs 0.00%
Long file (Parser) 800.6±1.79ns 800.5±0.79ns +0.01%
Mini js (Execution) 598.3±8.26µs 598.4±3.70µs -0.02%
Mini js (Full) 922.7±2.69µs 924.5±3.25µs -0.19%
Mini js (Parser) 36.2±0.06µs 36.0±0.14µs +0.56%
Number Object Access (Execution) 4.3±0.02µs 4.3±0.01µs 0.00%
Number Object Access (Full) 296.3±0.56µs 293.7±0.65µs +0.89%
Object Creation (Execution) 4.7±0.01µs 4.6±0.01µs +2.17%
Object Creation (Full) 301.9±1.56µs 295.1±0.53µs +2.30%
RegExp (Execution) 12.1±0.07µs 11.9±0.07µs +1.68%
RegExp (Full) 308.9±0.47µs 303.9±0.44µs +1.65%
RegExp Literal (Execution) 12.0±0.07µs 11.9±0.05µs +0.84%
RegExp Literal (Full) 313.4±0.78µs 307.8±0.80µs +1.82%
RegExp Literal Creation (Execution) 10.4±0.03µs 10.4±0.03µs 0.00%
RegExp Literal Creation (Full) 306.0±0.43µs 305.1±3.59µs +0.29%
Static Object Property Access (Execution) 4.9±0.02µs 4.9±0.02µs 0.00%
Static Object Property Access (Full) 298.2±0.46µs 299.9±0.62µs -0.57%
String Object Access (Execution) 7.6±0.05µs 7.5±0.03µs +1.33%
String Object Access (Full) 305.6±0.36µs 302.4±0.70µs +1.06%
String comparison (Execution) 6.7±0.02µs 6.8±0.02µs -1.47%
String comparison (Full) 301.8±0.64µs 304.9±0.54µs -1.02%
String concatenation (Execution) 5.4±0.01µs 5.6±0.02µs -3.57%
String concatenation (Full) 297.9±0.74µs 294.9±0.80µs +1.02%
String copy (Execution) 4.1±0.01µs 4.1±0.01µs 0.00%
String copy (Full) 288.4±0.53µs 288.9±1.00µs -0.17%
Symbols (Execution) 3.5±0.01µs 3.5±0.02µs 0.00%
Symbols (Full) 281.0±0.82µs 279.0±0.74µs +0.72%

@Razican Razican merged commit ad972f7 into master Jun 30, 2021
@HalidOdat HalidOdat deleted the doc_fix branch June 30, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation update documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants