-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement destructuring assignments #1406
Conversation
2c7de82
to
e5c1e50
Compare
The |
fb7aa05
to
3ae0ac4
Compare
The conformance improvement looks really good :)
Fixed tests:
Broken tests:
|
96437ee
to
ed528f3
Compare
Fixed tests:
Broken tests:
|
@HalidOdat I rebased this and moved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest a minor change to improve performance. And raise the issue of !
abrupt completions, but it can be done later.
ec5eed2
to
7cf86fa
Compare
Rebased. No change in 262 tests. @RageKnify I implemented your suggestions. |
Rename some fields for clarity Add some performance improvements
7cf86fa
to
be0974e
Compare
This Pull Request fixes/closes #265.
It changes the following:
To measure the completeness of this implementation, I looked at the
test/language/statements/const/dstr
262 test suite. Most tests are passing, with most of the failing ones being based on other features, e.g. generators.Though the code passes the tests, I'm not really sure about the implementation details, as this is my first contribution to the syntax and parser. I would really like some guidance on those parts, if anyone has time to go in depth on that.