Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change StringGetOwnProperty to produce the same strings that the lexer produces #1460

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

raskad
Copy link
Member

@raskad raskad commented Aug 10, 2021

This Pull Request fixes/closes #1459.

This changes StringGetOwnProperty to use String::from_utf16_lossy. This fixes the issue mentioned, but of course String::from_utf16_lossy is only a hack for the missing full UTF16 support. In my opinion it is the best way to go, as writing the codepoint as an escaped string may cause even more unexpected behavior.

@raskad
Copy link
Member Author

raskad commented Aug 10, 2021

Test result master count PR count difference
Total 78,897 78,897 0
Passed 29,629 29,633 +4
Ignored 15,612 15,612 0
Failed 33,656 33,652 -4
Panics 2 2 0
Conformance 37.55% 37.56% +0.01%
Fixed tests:
test/built-ins/RegExp/prototype/exec/u-captured-value.js [strict mode] (previously Failed)
test/built-ins/RegExp/prototype/exec/u-captured-value.js (previously Failed)
test/built-ins/Array/prototype/concat/Array.prototype.concat_spreadable-string-wrapper.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/concat/Array.prototype.concat_spreadable-string-wrapper.js (previously Failed)

@HalidOdat HalidOdat added bug Something isn't working execution Issues or PRs related to code execution labels Aug 11, 2021
@HalidOdat HalidOdat added this to the v0.13.0 milestone Aug 11, 2021
@HalidOdat HalidOdat merged commit e9093b3 into boa-dev:master Aug 11, 2021
@raskad raskad deleted the string-get-own-property-fix branch August 14, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StringGetOwnProperty does not produce the same strings that the lexer produces
2 participants