Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date refactor #1488

Merged
merged 4 commits into from
Aug 22, 2021
Merged

Date refactor #1488

merged 4 commits into from
Aug 22, 2021

Conversation

raskad
Copy link
Member

@raskad raskad commented Aug 20, 2021

It changes the following:

  • Handle high and negative values in new Date()
  • Refactor Date setter methods
  • Refactor some Date getter methods
  • Implement Date.prototype[Symbol.toPrimitive] method

@raskad
Copy link
Member Author

raskad commented Aug 20, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,897 78,897 0
Passed 29,824 29,984 +160
Ignored 15,612 15,612 0
Failed 33,461 33,301 -160
Panics 2 2 0
Conformance 37.80% 38.00% +0.20%
Fixed tests: 
test/built-ins/Date/S15.9.3.1_A5_T2.js [strict mode] (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T2.js (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T1.js [strict mode] (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T1.js (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T3.js [strict mode] (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T3.js (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T4.js [strict mode] (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T4.js (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T6.js [strict mode] (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T6.js (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T5.js [strict mode] (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T5.js (previously Failed)
test/built-ins/Date/UTC/return-value.js [strict mode] (previously Failed)
test/built-ins/Date/UTC/return-value.js (previously Failed)
test/built-ins/Date/prototype/getDay/this-value-valid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getDay/this-value-valid-date.js (previously Failed)
test/built-ins/Date/prototype/setUTCMinutes/S15.9.5.33_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setUTCMinutes/S15.9.5.33_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/setMilliseconds/arg-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMilliseconds/arg-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/getFullYear/this-value-valid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getFullYear/this-value-valid-date.js (previously Failed)
test/built-ins/Date/prototype/getTimezoneOffset/this-value-non-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getTimezoneOffset/this-value-non-date.js (previously Failed)
test/built-ins/Date/prototype/getTimezoneOffset/this-value-non-object.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getTimezoneOffset/this-value-non-object.js (previously Failed)
test/built-ins/Date/prototype/getTimezoneOffset/this-value-invalid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getTimezoneOffset/this-value-invalid-date.js (previously Failed)
test/built-ins/Date/prototype/setMonth/arg-month-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMonth/arg-month-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setMonth/arg-date-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMonth/arg-date-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setMonth/S15.9.5.38_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMonth/S15.9.5.38_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/setMonth/arg-date-to-number.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMonth/arg-date-to-number.js (previously Failed)
test/built-ins/Date/prototype/setUTCFullYear/S15.9.5.41_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setUTCFullYear/S15.9.5.41_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/setSeconds/arg-ms-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setSeconds/arg-ms-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setSeconds/arg-ms-to-number.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setSeconds/arg-ms-to-number.js (previously Failed)
test/built-ins/Date/prototype/setSeconds/S15.9.5.30_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setSeconds/S15.9.5.30_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/setSeconds/arg-sec-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setSeconds/arg-sec-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/getHours/this-value-valid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getHours/this-value-valid-date.js (previously Failed)
test/built-ins/Date/prototype/toTimeString/format.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toTimeString/format.js (previously Failed)
test/built-ins/Date/prototype/getMinutes/this-value-valid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getMinutes/this-value-valid-date.js (previously Failed)
test/built-ins/Date/prototype/getDate/this-value-valid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getDate/this-value-valid-date.js (previously Failed)
test/built-ins/Date/prototype/getSeconds/this-value-valid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getSeconds/this-value-valid-date.js (previously Failed)
test/built-ins/Date/prototype/setUTCHours/S15.9.5.35_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setUTCHours/S15.9.5.35_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/getMonth/this-value-valid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getMonth/this-value-valid-date.js (previously Failed)
test/built-ins/Date/prototype/setTime/arg-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setTime/arg-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/toJSON/length.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toJSON/length.js (previously Failed)
test/built-ins/Date/prototype/toJSON/invoke-result.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toJSON/invoke-result.js (previously Failed)
test/built-ins/Date/prototype/toJSON/to-primitive-abrupt.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toJSON/to-primitive-abrupt.js (previously Failed)
test/built-ins/Date/prototype/toJSON/to-primitive-value-of.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toJSON/to-primitive-value-of.js (previously Failed)
test/built-ins/Date/prototype/toJSON/to-object.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toJSON/to-object.js (previously Failed)
test/built-ins/Date/prototype/toJSON/invoke-abrupt.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toJSON/invoke-abrupt.js (previously Failed)
test/built-ins/Date/prototype/toJSON/invoke-arguments.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toJSON/invoke-arguments.js (previously Failed)
test/built-ins/Date/prototype/toJSON/non-finite.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toJSON/non-finite.js (previously Failed)
test/built-ins/Date/prototype/toJSON/to-primitive-symbol.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toJSON/to-primitive-symbol.js (previously Failed)
test/built-ins/Date/prototype/setDate/arg-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setDate/arg-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/toString/format.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toString/format.js (previously Failed)
test/built-ins/Date/prototype/toISOString/15.9.5.43-0-15.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toISOString/15.9.5.43-0-15.js (previously Failed)
test/built-ins/Date/prototype/toISOString/15.9.5.43-0-13.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toISOString/15.9.5.43-0-13.js (previously Failed)
test/built-ins/Date/prototype/toISOString/15.9.5.43-0-14.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toISOString/15.9.5.43-0-14.js (previously Failed)
test/built-ins/Date/prototype/toISOString/15.9.5.43-0-8.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toISOString/15.9.5.43-0-8.js (previously Failed)
test/built-ins/Date/prototype/getMilliseconds/this-value-valid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getMilliseconds/this-value-valid-date.js (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-ms-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-ms-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-ms-to-number.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-ms-to-number.js (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-min-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-min-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-sec-to-number.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-sec-to-number.js (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-sec-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-sec-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setMinutes/S15.9.5.32_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMinutes/S15.9.5.32_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-string-first-valid.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-string-first-valid.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/length.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/length.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-default-first-valid.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-default-first-valid.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-string-first-invalid.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-string-first-invalid.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-default-first-non-callable.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-default-first-non-callable.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/this-val-non-obj.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/this-val-non-obj.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-number-first-invalid.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-number-first-invalid.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-default-first-invalid.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-default-first-invalid.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-number-first-non-callable.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-number-first-non-callable.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-string-first-non-callable.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-string-first-non-callable.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-number-first-valid.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-number-first-valid.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/name.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/name.js (previously Failed)
test/built-ins/Date/prototype/setHours/arg-ms-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setHours/arg-ms-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setHours/S15.9.5.34_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setHours/S15.9.5.34_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/setHours/arg-hour-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setHours/arg-hour-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setHours/arg-min-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setHours/arg-min-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setHours/arg-sec-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setHours/arg-sec-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-month-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-month-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setFullYear/S15.9.5.40_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setFullYear/S15.9.5.40_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-date-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-date-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-month-to-number.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-month-to-number.js (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-year-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-year-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-date-to-number.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-date-to-number.js (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-year-to-number.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-year-to-number.js (previously Failed)
test/built-ins/Date/prototype/setUTCMonth/S15.9.5.39_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setUTCMonth/S15.9.5.39_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/setUTCSeconds/S15.9.5.31_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setUTCSeconds/S15.9.5.31_A2_T1.js (previously Failed)
test/annexB/built-ins/Date/prototype/setYear/this-time-nan.js [strict mode] (previously Failed)
test/annexB/built-ins/Date/prototype/setYear/this-time-nan.js (previously Failed)
test/annexB/built-ins/Date/prototype/setYear/year-to-number-err.js [strict mode] (previously Failed)
test/annexB/built-ins/Date/prototype/setYear/year-to-number-err.js (previously Failed)
test/language/expressions/addition/S11.6.1_A2.2_T2.js [strict mode] (previously Failed)
test/language/expressions/addition/S11.6.1_A2.2_T2.js (previously Failed)
Broken tests: 
test/built-ins/Date/prototype/toJSON/called-as-function.js [strict mode] (previously Passed)
test/built-ins/Date/prototype/toJSON/called-as-function.js (previously Passed)
test/built-ins/Date/prototype/Symbol.toPrimitive/called-as-function.js [strict mode] (previously Passed)
test/built-ins/Date/prototype/Symbol.toPrimitive/called-as-function.js (previously Passed)

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Aug 21, 2021
@HalidOdat HalidOdat added this to the v0.13.0 milestone Aug 21, 2021
HalidOdat
HalidOdat reviewed Aug 21, 2021
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

boa/src/builtins/date/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/date/mod.rs Outdated Show resolved Hide resolved
@raskad
Copy link
Member Author

raskad commented Aug 21, 2021

Rebased and changes applied.

Test262 conformance changes:

Test result master count PR count difference
Total 78,897 78,897 0
Passed 30,922 31,084 +162
Ignored 15,612 15,612 0
Failed 32,363 32,201 -162
Panics 2 2 0
Conformance 39.19% 39.40% +0.21%
Fixed tests: 
test/built-ins/Date/S15.9.3.1_A5_T2.js [strict mode] (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T2.js (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T1.js [strict mode] (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T1.js (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T3.js [strict mode] (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T3.js (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T4.js [strict mode] (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T4.js (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T6.js [strict mode] (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T6.js (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T5.js [strict mode] (previously Failed)
test/built-ins/Date/S15.9.3.1_A5_T5.js (previously Failed)
test/built-ins/Date/UTC/return-value.js [strict mode] (previously Failed)
test/built-ins/Date/UTC/return-value.js (previously Failed)
test/built-ins/Date/prototype/getDay/this-value-valid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getDay/this-value-valid-date.js (previously Failed)
test/built-ins/Date/prototype/setUTCMinutes/S15.9.5.33_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setUTCMinutes/S15.9.5.33_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/setMilliseconds/arg-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMilliseconds/arg-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/getFullYear/this-value-valid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getFullYear/this-value-valid-date.js (previously Failed)
test/built-ins/Date/prototype/getTimezoneOffset/this-value-non-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getTimezoneOffset/this-value-non-date.js (previously Failed)
test/built-ins/Date/prototype/getTimezoneOffset/this-value-non-object.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getTimezoneOffset/this-value-non-object.js (previously Failed)
test/built-ins/Date/prototype/getTimezoneOffset/this-value-invalid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getTimezoneOffset/this-value-invalid-date.js (previously Failed)
test/built-ins/Date/prototype/setMonth/arg-month-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMonth/arg-month-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setMonth/arg-date-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMonth/arg-date-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setMonth/S15.9.5.38_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMonth/S15.9.5.38_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/setMonth/arg-date-to-number.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMonth/arg-date-to-number.js (previously Failed)
test/built-ins/Date/prototype/setUTCFullYear/S15.9.5.41_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setUTCFullYear/S15.9.5.41_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/setSeconds/arg-ms-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setSeconds/arg-ms-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setSeconds/arg-ms-to-number.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setSeconds/arg-ms-to-number.js (previously Failed)
test/built-ins/Date/prototype/setSeconds/S15.9.5.30_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setSeconds/S15.9.5.30_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/setSeconds/arg-sec-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setSeconds/arg-sec-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/getHours/this-value-valid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getHours/this-value-valid-date.js (previously Failed)
test/built-ins/Date/prototype/toTimeString/format.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toTimeString/format.js (previously Failed)
test/built-ins/Date/prototype/getMinutes/this-value-valid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getMinutes/this-value-valid-date.js (previously Failed)
test/built-ins/Date/prototype/getDate/this-value-valid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getDate/this-value-valid-date.js (previously Failed)
test/built-ins/Date/prototype/getSeconds/this-value-valid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getSeconds/this-value-valid-date.js (previously Failed)
test/built-ins/Date/prototype/setUTCHours/S15.9.5.35_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setUTCHours/S15.9.5.35_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/getMonth/this-value-valid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getMonth/this-value-valid-date.js (previously Failed)
test/built-ins/Date/prototype/setTime/arg-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setTime/arg-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/toJSON/length.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toJSON/length.js (previously Failed)
test/built-ins/Date/prototype/toJSON/invoke-result.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toJSON/invoke-result.js (previously Failed)
test/built-ins/Date/prototype/toJSON/to-primitive-abrupt.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toJSON/to-primitive-abrupt.js (previously Failed)
test/built-ins/Date/prototype/toJSON/to-primitive-value-of.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toJSON/to-primitive-value-of.js (previously Failed)
test/built-ins/Date/prototype/toJSON/to-object.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toJSON/to-object.js (previously Failed)
test/built-ins/Date/prototype/toJSON/invoke-abrupt.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toJSON/invoke-abrupt.js (previously Failed)
test/built-ins/Date/prototype/toJSON/invoke-arguments.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toJSON/invoke-arguments.js (previously Failed)
test/built-ins/Date/prototype/toJSON/non-finite.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toJSON/non-finite.js (previously Failed)
test/built-ins/Date/prototype/toJSON/to-primitive-symbol.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toJSON/to-primitive-symbol.js (previously Failed)
test/built-ins/Date/prototype/setDate/arg-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setDate/arg-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/toString/format.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toString/format.js (previously Failed)
test/built-ins/Date/prototype/toISOString/15.9.5.43-0-15.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toISOString/15.9.5.43-0-15.js (previously Failed)
test/built-ins/Date/prototype/toISOString/15.9.5.43-0-13.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toISOString/15.9.5.43-0-13.js (previously Failed)
test/built-ins/Date/prototype/toISOString/15.9.5.43-0-14.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toISOString/15.9.5.43-0-14.js (previously Failed)
test/built-ins/Date/prototype/toISOString/15.9.5.43-0-8.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toISOString/15.9.5.43-0-8.js (previously Failed)
test/built-ins/Date/prototype/getMilliseconds/this-value-valid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/getMilliseconds/this-value-valid-date.js (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-ms-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-ms-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-ms-to-number.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-ms-to-number.js (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-min-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-min-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-sec-to-number.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-sec-to-number.js (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-sec-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMinutes/arg-sec-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setMinutes/S15.9.5.32_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setMinutes/S15.9.5.32_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-string-first-valid.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-string-first-valid.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/length.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/length.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-default-first-valid.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-default-first-valid.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-string-first-invalid.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-string-first-invalid.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-default-first-non-callable.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-default-first-non-callable.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/this-val-non-obj.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/this-val-non-obj.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-invalid.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-invalid.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-number-first-invalid.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-number-first-invalid.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-default-first-invalid.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-default-first-invalid.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-number-first-non-callable.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-number-first-non-callable.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-string-first-non-callable.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-string-first-non-callable.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-number-first-valid.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/hint-number-first-valid.js (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/name.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/Symbol.toPrimitive/name.js (previously Failed)
test/built-ins/Date/prototype/setHours/arg-ms-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setHours/arg-ms-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setHours/S15.9.5.34_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setHours/S15.9.5.34_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/setHours/arg-hour-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setHours/arg-hour-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setHours/arg-min-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setHours/arg-min-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setHours/arg-sec-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setHours/arg-sec-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-month-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-month-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setFullYear/S15.9.5.40_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setFullYear/S15.9.5.40_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-date-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-date-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-month-to-number.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-month-to-number.js (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-year-to-number-err.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-year-to-number-err.js (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-date-to-number.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-date-to-number.js (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-year-to-number.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setFullYear/arg-year-to-number.js (previously Failed)
test/built-ins/Date/prototype/setUTCMonth/S15.9.5.39_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setUTCMonth/S15.9.5.39_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/setUTCSeconds/S15.9.5.31_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setUTCSeconds/S15.9.5.31_A2_T1.js (previously Failed)
test/annexB/built-ins/Date/prototype/setYear/this-time-nan.js [strict mode] (previously Failed)
test/annexB/built-ins/Date/prototype/setYear/this-time-nan.js (previously Failed)
test/annexB/built-ins/Date/prototype/setYear/year-to-number-err.js [strict mode] (previously Failed)
test/annexB/built-ins/Date/prototype/setYear/year-to-number-err.js (previously Failed)
test/language/expressions/addition/S11.6.1_A2.2_T2.js [strict mode] (previously Failed)
test/language/expressions/addition/S11.6.1_A2.2_T2.js (previously Failed)
Broken tests: 
test/built-ins/Date/prototype/toJSON/called-as-function.js [strict mode] (previously Passed)
test/built-ins/Date/prototype/toJSON/called-as-function.js (previously Passed)
test/built-ins/Date/prototype/Symbol.toPrimitive/called-as-function.js [strict mode] (previously Passed)
test/built-ins/Date/prototype/Symbol.toPrimitive/called-as-function.js (previously Passed)

@HalidOdat HalidOdat merged commit eaaae85 into boa-dev:master Aug 22, 2021
@raskad raskad deleted the date-refactor branch September 10, 2021 23:23
@raskad raskad mentioned this pull request Sep 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@raskad @HalidOdat