Handle white spaces as described in ECMAScript specs #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonwilliams
requested changes
Oct 15, 2019
There was a problem hiding this comment.
Looks good, although it might help to have comments like this one for string:
https://github.com/jasonwilliams/boa/blob/master/src/lib/js/string.rs#L529-L545
|
thanks for your suggestion, I've edited it accordingly. |
jasonwilliams
approved these changes
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This solves the issue: #154
I've simply added all whitespace characters defined in the ECMAScript specification in the main
fn lex()loop.I've followed this part of the specification, according to the code points defined here.
I hope this helps,
thank you for your time,
Evomassiny