Rewrite initialization of builtins to use the BuiltIn
trait
#1586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently aren't using the
BuiltIn
trait to check the initialization of builtins, meaning any struct that implements ainit
function that returns a(&str, Value, Attribute)
tuple can be used to initialize a global builtin.This PR changes the following:
BuiltIn::init
to return only aJsValue
and convertsBuiltIn::attribute
into a constant.BuiltIn
trait.globals!
macro to avoid the boilerplate.