Implement String.fromCharCode #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hle0 <91701075+hle0@users.noreply.github.com>
Test262 conformance changes:
Fixed tests (78): |
jedel1043
reviewed
Oct 3, 2021
Comment on lines
+258
to
+264
| let mut elements = Vec::new(); | ||
| // 3. For each element next of codeUnits, do | ||
| for next in args { | ||
| // 3a. Let nextCU be ℝ(? ToUint16(next)). | ||
| // 3b. Append nextCU to the end of elements. | ||
| elements.push(next.to_u32(context)? as u16); | ||
| } |
There was a problem hiding this comment.
Just noting that, when #1552 gets merged, this should be simplified further to:
args.iter()
.map(|val| val.to_u16(context))
.collect::<JsResult<Vec<_>>>()?;
raskad
approved these changes
Oct 3, 2021
jedel1043
added
builtins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hle0 91701075+hle0@users.noreply.github.com
This pull request changes the following:
String.fromCharCode(...)per the ECMAScript spec