[Merged by Bors] - refactor: fix construct_error functions #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the interpreter would create the AST equivalent to `new Error(message)` and interpret it when constructing the builtin errors, this would fail if the gloabl in question is overwritten. Now we use `Context::standard_objects` to get access to the error constructors and invoke the functions directly.
Codecov Report
@@ Coverage Diff @@
## main #1703 +/- ##
==========================================
- Coverage 50.85% 50.76% -0.09%
==========================================
Files 199 199
Lines 17803 17820 +17
==========================================
- Hits 9053 9047 -6
- Misses 8750 8773 +23
Continue to review full report at Codecov.
|
Test262 conformance changesNon-VM implementation
VM implementation
|
RageKnify
requested review from
HalidOdat,
0x7D2B,
jasonwilliams,
jedel1043,
Lan2u,
raskad,
Razican and
tofpie
jasonwilliams
approved these changes
Nov 11, 2021
raskad
approved these changes
Nov 14, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 14, 2021
Before the interpreter would create the AST equivalent to `new Error(message)` and interpret it when constructing the builtin errors, this could fail if the gloabl in question had been overwritten. Now we use `Context::standard_objects` to get access to the error constructors and invoke the functions directly.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the interpreter would create the AST equivalent to
new Error(message)and interpret it when constructing the builtin errors, this could fail if the gloabl in question had been overwritten. Now we useContext::standard_objectsto get access to theerror constructors and invoke the functions directly.