Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Removed a bunch of warnings and clippy errors #1754

Closed
wants to merge 2 commits into from

Conversation

Razican
Copy link
Member

@Razican Razican commented Dec 21, 2021

This Pull Request fixes some warnings and clips errors. It conflicts with the VM/non-VM PR, so should probably go in first, so that this branch gets properly updated and we get the list of real warnings/errors there.

@Razican Razican added the bug Something isn't working label Dec 21, 2021
@Razican Razican added this to the v0.14.0 milestone Dec 21, 2021
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #1754 (f72859f) into main (d124c12) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1754   +/-   ##
=======================================
  Coverage   53.03%   53.03%           
=======================================
  Files         200      200           
  Lines       17076    17076           
=======================================
  Hits         9056     9056           
  Misses       8020     8020           
Impacted Files Coverage Δ
boa/src/environment/lexical_environment.rs 81.81% <ø> (ø)
boa/src/lib.rs 81.57% <ø> (ø)
boa_tester/src/main.rs 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d124c12...f72859f. Read the comment docs.

@github-actions
Copy link

Test262 conformance changes

Non-VM implementation

Test result main count PR count difference
Total 86,952 86,952 0
Passed 40,157 40,157 0
Ignored 19,269 19,269 0
Failed 27,526 27,526 0
Panics 0 0 0
Conformance 46.18% 46.18% 0.00%

VM implementation

Test result main count PR count difference
Total 86,952 86,952 0
Passed 40,847 40,847 0
Ignored 19,269 19,269 0
Failed 26,836 26,836 0
Panics 0 0 0
Conformance 46.98% 46.98% 0.00%

@Razican
Copy link
Member Author

Razican commented Dec 23, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 23, 2021
This Pull Request fixes some warnings and clips errors. It conflicts with the VM/non-VM PR, so should probably go in first, so that this branch gets properly updated and we get the list of real warnings/errors there.
@bors
Copy link

bors bot commented Dec 23, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Removed a bunch of warnings and clippy errors [Merged by Bors] - Removed a bunch of warnings and clippy errors Dec 23, 2021
@bors bors bot closed this Dec 23, 2021
@bors bors bot deleted the fix_test_warnings branch December 23, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants