[Merged by Bors] - Update the PR benchmarks action #1774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #1774 +/- ##
==========================================
- Coverage 56.30% 55.51% -0.79%
==========================================
Files 200 201 +1
Lines 17049 17420 +371
==========================================
+ Hits 9599 9671 +72
- Misses 7450 7749 +299
Continue to review full report at Codecov.
|
Benchmark for 7494616Click to view benchmark
|
|
This is now ready to be merged :) |
Razican
requested review from
jasonwilliams,
HalidOdat,
jedel1043,
RageKnify and
raskad
Razican
changed the title
jedel1043
reviewed
Jan 29, 2022
There was a problem hiding this comment.
Also, I realized the criterion-compare-action repo didn't have a version bump to 3.0.1 on the package.json (https://github.com/boa-dev/criterion-compare-action/blob/b12b240867eafcd503e063c17db8db3c4ab50d7e/package.json#L3)
.github/workflows/pull_request.yml
Outdated
| @@ -21,8 +21,8 @@ jobs: | |||
| ~/.cargo/git | |||
| ~/.cargo/registry | |||
| key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} | |||
| - uses: boa-dev/criterion-compare-action@master | |||
| - uses: boa-dev/criterion-compare-action@v3.0.1 | |||
There was a problem hiding this comment.
Is there a reason for pinning the action to the version 3.0.1? We could use main to avoid having to bump the version on every new change.
There was a problem hiding this comment.
The idea behind this is to follow the nomenclature with the rest of actions. This action is now being used by more projects, not only Boa, so we should use the released versions. That way we can also develop the action in the main branch as needed, and release new versions with new features. Also, @dependabot will create PRs to update the action if we do it like this.
I will update this, I forgot it :/ |
Fixed the version, released a new one and updated the GitHub action. |
Benchmark for c9be5afClick to view benchmark
|
Benchmark for 30df9fbClick to view benchmark
|
RageKnify
approved these changes
Jan 29, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 29, 2022
This is just for debugging for now. If we find out a fix, we can merge it.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just for debugging for now. If we find out a fix, we can merge it.