-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - add more timers on object functions #1775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jasonwilliams
commented
Jan 5, 2022
•
edited
Loading
edited
Codecov Report
@@ Coverage Diff @@
## main #1775 +/- ##
==========================================
- Coverage 56.30% 56.21% -0.09%
==========================================
Files 200 200
Lines 17049 17074 +25
==========================================
Hits 9599 9599
- Misses 7450 7475 +25
Continue to review full report at Codecov.
|
Razican
approved these changes
Jan 6, 2022
raskad
approved these changes
Jan 11, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 11, 2022
``` +------------------------------------------------+-----------+-----------------+----------+------------+ | Item | Self time | % of total time | Time | Item count | +------------------------------------------------+-----------+-----------------+----------+------------+ | run | 14.27ms | 15.545 | 161.26ms | 56 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Object::__get_own_property__ | 9.28ms | 10.115 | 12.67ms | 5412 | +------------------------------------------------+-----------+-----------------+----------+------------+ | LexicalEnvironment::get_binding_value | 9.10ms | 9.918 | 22.00ms | 1066 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Object::validate_and_apply_property_descriptor | 6.12ms | 6.669 | 6.12ms | 677 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Object::ordinary_set | 4.07ms | 4.434 | 39.14ms | 818 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Object::ordinary_get_own_property | 3.60ms | 3.922 | 3.60ms | 5720 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Object::__call__ | 3.22ms | 3.505 | 103.95ms | 410 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Object::ordinary_define_own_property | 3.10ms | 3.379 | 10.90ms | 677 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Object::ordinary_has_property | 2.95ms | 3.209 | 7.17ms | 1772 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Object::__has_property__ | 2.85ms | 3.107 | 10.02ms | 1772 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Object::ordinary_get | 2.85ms | 3.104 | 8.14ms | 1632 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Object::__get__ | 2.81ms | 3.063 | 10.95ms | 1632 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - GetName | 2.56ms | 2.789 | 24.56ms | 1066 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Object::__define_own_property__ | 2.48ms | 2.704 | 13.58ms | 521 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - SetName | 1.81ms | 1.972 | 9.52ms | 202 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - Call | 1.35ms | 1.473 | 103.28ms | 356 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Object::__set__ | 1.29ms | 1.401 | 40.43ms | 818 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - GetPropertyByName | 1.24ms | 1.354 | 4.95ms | 355 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Date | 1.07ms | 1.171 | 1.08ms | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Object::__get_prototype_of__ | 1.06ms | 1.151 | 1.21ms | 621 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - GetPropertyByValue | 1.05ms | 1.143 | 1.91ms | 154 | +------------------------------------------------+-----------+-----------------+----------+------------+ | create_intrinsics | 871.52µs | 0.949 | 7.92ms | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Array | 761.02µs | 0.829 | 763.84µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Opcode retrieval | 756.35µs | 0.824 | 756.35µs | 4941 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Math | 750.16µs | 0.817 | 753.72µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Object | 618.59µs | 0.674 | 620.77µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | String | 611.83µs | 0.667 | 614.46µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | RegExp | 419.63µs | 0.457 | 421.09µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | next() | 339.03µs | 0.369 | 849.73µs | 96 | +------------------------------------------------+-----------+-----------------+----------+------------+ | console | 332.59µs | 0.362 | 334.02µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Identifier | 318.53µs | 0.347 | 337.39µs | 30 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - DefInitArg | 305.43µs | 0.333 | 305.43µs | 54 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Reflect | 265.70µs | 0.289 | 267.45µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - Dup | 260.49µs | 0.284 | 260.49µs | 555 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Number | 225.72µs | 0.246 | 305.09µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | BigInt64Array | 220.31µs | 0.240 | 220.54µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Map | 208.40µs | 0.227 | 209.97µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - PushInt8 | 201.64µs | 0.220 | 201.64µs | 402 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Set | 196.16µs | 0.214 | 197.64µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - Pop | 191.73µs | 0.209 | 191.73µs | 455 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Symbol | 186.95µs | 0.204 | 188.13µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Object::__is_extensible__ | 159.01µs | 0.173 | 159.01µs | 677 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - LessThan | 152.95µs | 0.167 | 152.95µs | 202 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Object::ordinary_get_prototype_of | 152.01µs | 0.166 | 152.01µs | 621 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Main | 150.58µs | 0.164 | 82.11ms | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - Inc | 134.81µs | 0.147 | 134.81µs | 200 | +------------------------------------------------+-----------+-----------------+----------+------------+ | AssignmentExpression | 113.77µs | 0.124 | 4.08ms | 21 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - JumpIfFalse | 103.93µs | 0.113 | 103.93µs | 202 | +------------------------------------------------+-----------+-----------------+----------+------------+ | function | 103.75µs | 0.113 | 104.33µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | MemberExpression | 97.28µs | 0.106 | 2.30ms | 26 | +------------------------------------------------+-----------+-----------------+----------+------------+ | make_builtin_fn: next | 94.48µs | 0.103 | 100.99µs | 6 | +------------------------------------------------+-----------+-----------------+----------+------------+ | From<JsObject> | 83.55µs | 0.091 | 83.55µs | 2582 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - Jump | 83.45µs | 0.091 | 83.45µs | 202 | +------------------------------------------------+-----------+-----------------+----------+------------+ | ArrayBuffer | 82.91µs | 0.090 | 84.38µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Realm::create | 82.24µs | 0.090 | 93.74µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | BigInt | 79.60µs | 0.087 | 81.04µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | LeftHandSIdeExpression | 76.08µs | 0.083 | 3.04ms | 25 | +------------------------------------------------+-----------+-----------------+----------+------------+ | NumberLiteral | 70.64µs | 0.077 | 99.63µs | 7 | +------------------------------------------------+-----------+-----------------+----------+------------+ | MultiplicativeExpression | 68.45µs | 0.075 | 3.38ms | 24 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - Mul | 66.50µs | 0.072 | 66.50µs | 100 | +------------------------------------------------+-----------+-----------------+----------+------------+ | StatementList | 66.01µs | 0.072 | 3.70ms | 3 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - GreaterThan | 61.54µs | 0.067 | 61.54µs | 100 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - GetFunction | 52.91µs | 0.058 | 175.00µs | 2 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Float32Array | 52.62µs | 0.057 | 52.82µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | From<String> | 50.52µs | 0.055 | 50.52µs | 431 | +------------------------------------------------+-----------+-----------------+----------+------------+ | ExponentiationExpression | 48.15µs | 0.052 | 3.31ms | 25 | +------------------------------------------------+-----------+-----------------+----------+------------+ | PrimaryExpression | 47.01µs | 0.051 | 1.82ms | 25 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - LogicalAnd | 46.79µs | 0.051 | 46.79µs | 100 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Boolean | 42.78µs | 0.047 | 43.08µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Int8Array | 41.96µs | 0.046 | 42.18µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Float64Array | 41.36µs | 0.045 | 41.57µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | BigUint64Array | 41.12µs | 0.045 | 41.34µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Uint16Array | 40.82µs | 0.044 | 41.03µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Uint8Array | 40.68µs | 0.044 | 40.89µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Uint32Array | 40.61µs | 0.044 | 40.81µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | JSON | 40.59µs | 0.044 | 41.73µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Int32Array | 40.57µs | 0.044 | 40.79µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Uint8ClampedArray | 40.47µs | 0.044 | 40.69µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Int16Array | 40.37µs | 0.044 | 40.57µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | BitwiseANDExpression | 39.90µs | 0.043 | 3.56ms | 21 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Error | 39.58µs | 0.043 | 40.62µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | UpdateExpression | 39.50µs | 0.043 | 3.08ms | 25 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - RestParameterPop | 39.29µs | 0.043 | 39.29µs | 55 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Arguments | 37.25µs | 0.041 | 689.94µs | 7 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Relation Expression | 36.74µs | 0.040 | 3.49ms | 21 | +------------------------------------------------+-----------+-----------------+----------+------------+ | AdditiveExpression | 36.23µs | 0.039 | 3.42ms | 24 | +------------------------------------------------+-----------+-----------------+----------+------------+ | SyntaxError | 34.38µs | 0.037 | 35.85µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | ShiftExpression | 34.17µs | 0.037 | 3.45ms | 24 | +------------------------------------------------+-----------+-----------------+----------+------------+ | ReferenceError | 33.10µs | 0.036 | 34.17µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | TypeError | 32.79µs | 0.036 | 33.79µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | EvalError | 32.17µs | 0.035 | 33.43µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | URIError | 32.05µs | 0.035 | 33.35µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | ShortCircuitExpression | 32.02µs | 0.035 | 3.65ms | 20 | +------------------------------------------------+-----------+-----------------+----------+------------+ | BitwiseORExpression | 30.85µs | 0.034 | 3.62ms | 21 | +------------------------------------------------+-----------+-----------------+----------+------------+ | EqualityExpression | 30.82µs | 0.034 | 3.52ms | 21 | +------------------------------------------------+-----------+-----------------+----------+------------+ | BitwiseXORExpression | 30.80µs | 0.034 | 3.59ms | 21 | +------------------------------------------------+-----------+-----------------+----------+------------+ | ConditionalExpression | 29.84µs | 0.033 | 3.68ms | 20 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Operator | 28.55µs | 0.031 | 30.56µs | 13 | +------------------------------------------------+-----------+-----------------+----------+------------+ | ForStatement | 28.09µs | 0.031 | 1.18ms | 2 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Proxy | 28.02µs | 0.031 | 28.19µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | cursor::next_char() | 27.88µs | 0.030 | 27.88µs | 147 | +------------------------------------------------+-----------+-----------------+----------+------------+ | cursor::next_is_ascii_pred() | 26.11µs | 0.028 | 27.33µs | 21 | +------------------------------------------------+-----------+-----------------+----------+------------+ | VariableStatement | 25.01µs | 0.027 | 224.24µs | 2 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Intl | 23.92µs | 0.026 | 24.90µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Statement | 23.60µs | 0.026 | 4.26ms | 9 | +------------------------------------------------+-----------+-----------------+----------+------------+ | RangeError | 23.47µs | 0.026 | 24.56µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - DefInitVar | 20.60µs | 0.022 | 49.41µs | 2 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - Return | 20.47µs | 0.022 | 20.47µs | 55 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Expression | 20.13µs | 0.022 | 3.27ms | 13 | +------------------------------------------------+-----------+-----------------+----------+------------+ | CallExpression | 19.32µs | 0.021 | 714.52µs | 6 | +------------------------------------------------+-----------+-----------------+----------+------------+ | make_builtin_fn: parseInt | 19.31µs | 0.021 | 20.46µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Iterator Prototype | 18.91µs | 0.021 | 18.99µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | String Iterator | 18.66µs | 0.020 | 37.92µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | make_builtin_fn: isNaN | 18.43µs | 0.020 | 19.50µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | make_builtin_fn: parseFloat | 18.37µs | 0.020 | 19.41µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | make_builtin_fn: isFinite | 18.11µs | 0.020 | 19.13µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | ArrowFunction | 16.54µs | 0.018 | 80.56µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | cursor::next_is() | 16.24µs | 0.018 | 16.40µs | 5 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - PushZero | 15.39µs | 0.017 | 15.39µs | 56 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - PushUndefined | 13.76µs | 0.015 | 13.76µs | 55 | +------------------------------------------------+-----------+-----------------+----------+------------+ | UnaryExpression | 11.52µs | 0.013 | 3.75ms | 2 | +------------------------------------------------+-----------+-----------------+----------+------------+ | LexicalEnvironment::new | 11.15µs | 0.012 | 11.20µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | cursor::peek_char() | 10.27µs | 0.011 | 10.27µs | 78 | +------------------------------------------------+-----------+-----------------+----------+------------+ | LexicalEnvironment::has_binding | 10.22µs | 0.011 | 28.81µs | 2 | +------------------------------------------------+-----------+-----------------+----------+------------+ | ArrayIterator | 10.09µs | 0.011 | 28.84µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | StatementListItem | 9.83µs | 0.011 | 3.57ms | 7 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Object::__construct__ | 9.80µs | 0.011 | 31.22µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - PushDeclarativeEnvironment | 9.31µs | 0.010 | 9.71µs | 2 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - PushNewArray | 9.19µs | 0.010 | 24.97µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | ExpressionStatement | 9.06µs | 0.010 | 2.80ms | 5 | +------------------------------------------------+-----------+-----------------+----------+------------+ | ForInIterator | 8.71µs | 0.009 | 26.32µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | SetIterator | 8.67µs | 0.009 | 26.13µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | RegExp String Iterator | 8.47µs | 0.009 | 25.15µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | MapIterator | 8.47µs | 0.009 | 25.54µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | FunctionExpression | 7.08µs | 0.008 | 1.77ms | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | SpreadLiteral | 6.89µs | 0.008 | 23.29µs | 5 | +------------------------------------------------+-----------+-----------------+----------+------------+ | new_declarative_environment | 6.76µs | 0.007 | 6.76µs | 59 | +------------------------------------------------+-----------+-----------------+----------+------------+ | FunctionStatementList | 5.80µs | 0.006 | 1.82ms | 2 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - New | 5.65µs | 0.006 | 36.90µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | cursor::peek() | 4.65µs | 0.005 | 4.65µs | 59 | +------------------------------------------------+-----------+-----------------+----------+------------+ | FormalParameters | 4.54µs | 0.005 | 6.33µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - This | 3.50µs | 0.004 | 3.53µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Object::get_prototype_from_constructor | 3.42µs | 0.004 | 9.07µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | cursor::set_goal() | 3.33µs | 0.004 | 3.33µs | 99 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Initializer | 3.29µs | 0.004 | 161.59µs | 2 | +------------------------------------------------+-----------+-----------------+----------+------------+ | BindingIdentifier | 3.27µs | 0.004 | 3.27µs | 3 | +------------------------------------------------+-----------+-----------------+----------+------------+ | ArrayLiteral | 2.42µs | 0.003 | 3.98µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | globalThis | 1.35µs | 0.001 | 1.38µs | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - PopEnvironment | 1.23µs | 0.001 | 1.23µs | 2 | +------------------------------------------------+-----------+-----------------+----------+------------+ | cursor::next_byte() | 943.00ns | 0.001 | 943.00ns | 11 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - Swap | 841.00ns | 0.001 | 841.00ns | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - LogicalNot | 661.00ns | 0.001 | 661.00ns | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - PopOnReturnAdd | 351.00ns | 0.000 | 351.00ns | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | INST - PopOnReturnSub | 211.00ns | 0.000 | 211.00ns | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Infinity | 160.00ns | 0.000 | 160.00ns | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | undefined | 140.00ns | 0.000 | 140.00ns | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | NaN | 130.00ns | 0.000 | 130.00ns | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Execute | 70.00ns | 0.000 | 70.00ns | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ | Compilation | 40.00ns | 0.000 | 40.00ns | 1 | +------------------------------------------------+-----------+-----------------+----------+------------+ Total cpu time: 91.797457ms +------+---------------+ | Item | Artifact Size | +------+---------------+ ```
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
add more timers on object functions
[Merged by Bors] - add more timers on object functions
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.