[Merged by Bors] - General code clean-up and new lint addition #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
requested review from
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
jedel1043
Test262 conformance changesVM implementation
|
Benchmark for 523a566Click to view benchmark
|
Benchmark for bb0c71dClick to view benchmark
|
Codecov Report
@@ Coverage Diff @@
## main #1809 +/- ##
==========================================
+ Coverage 55.49% 55.73% +0.23%
==========================================
Files 201 201
Lines 17390 17326 -64
==========================================
+ Hits 9650 9656 +6
+ Misses 7740 7670 -70
Continue to review full report at Codecov.
|
Benchmark for 4e5ea24Click to view benchmark
|
raskad
approved these changes
Jan 31, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 3, 2022
This PR adds some Clippy lints. Mainly, it adds the list of pedantic lints excluding some lints that were causing too many warnings. I also denied some useful restriction and pedantic lints, to make sure we use `Self` all the possible times (for better maintainability), and that we pass elements by reference where possible, for example, or that the documentation is properly written. This might even have some small performance gains. I also added a perfect hash function for the CLI keywords, which should be more efficient than a `HashSet`. This is something we could use elsewhere too.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some Clippy lints. Mainly, it adds the list of pedantic lints excluding some lints that were causing too many warnings. I also denied some useful restriction and pedantic lints, to make sure we use
Selfall the possible times (for better maintainability), and that we pass elements by reference where possible, for example, or that the documentation is properly written.This might even have some small performance gains.
I also added a perfect hash function for the CLI keywords, which should be more efficient than a
HashSet. This is something we could use elsewhere too.