-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix wasm use outside browsers #1846
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
added
dependencies
Pull requests that update a dependency file
webassembly
Anything related to using Boa with WASM
labels
Feb 18, 2022
Codecov Report
@@ Coverage Diff @@
## main #1846 +/- ##
=======================================
Coverage 55.60% 55.60%
=======================================
Files 201 201
Lines 17397 17397
=======================================
Hits 9674 9674
Misses 7723 7723 Continue to review full report at Codecov.
|
Test262 conformance changesVM implementation
|
Benchmark for b2e87bbClick to view benchmark
|
RageKnify
approved these changes
Feb 19, 2022
Razican
requested review from
jasonwilliams,
HalidOdat,
jedel1043 and
raskad
February 20, 2022 19:15
jedel1043
approved these changes
Feb 20, 2022
bors r+ |
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Fix wasm use outside browsers
[Merged by Bors] - Fix wasm use outside browsers
Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
webassembly
Anything related to using Boa with WASM
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #1670.
It changes the following:
Note that this change was introduced in #1521, after #1475. We must make sure that the issue doesn't come back.