-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix equality between objects and undefined
or null
#1872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
bug
Something isn't working
execution
Issues or PRs related to code execution
labels
Feb 27, 2022
HalidOdat
requested review from
jasonwilliams,
jedel1043,
RageKnify,
raskad and
Razican
February 27, 2022 16:45
Test262 conformance changesVM implementation
Fixed tests (14):
|
Codecov Report
@@ Coverage Diff @@
## main #1872 +/- ##
=======================================
Coverage 46.67% 46.67%
=======================================
Files 204 204
Lines 16701 16701
=======================================
Hits 7796 7796
Misses 8905 8905
Continue to review full report at Codecov.
|
jedel1043
approved these changes
Feb 27, 2022
Razican
approved these changes
Feb 27, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 27, 2022
This PR fixes equality between object and `null` or `undefined` (like `[] == null`), which was failing the test262 harness test [`compare-array-symbol.js`](https://github.com/tc39/test262/blob/18ce639a4c4768de337fa30b83bbb6de02b0e1a5/test/harness/compare-array-symbol.js).
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Fix equality between objects and
[Merged by Bors] - Fix equality between objects and Feb 27, 2022
undefined
or null
undefined
or null
Benchmark for 19bf048Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes equality between object and
null
orundefined
(like[] == null
), which was failing the test262 harness testcompare-array-symbol.js
.