[Merged by Bors] - Extract Intrinsics struct from Context and cleanup names
#1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
builtins
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #1890 +/- ##
==========================================
- Coverage 46.58% 46.41% -0.18%
==========================================
Files 206 206
Lines 16781 16790 +9
==========================================
- Hits 7818 7793 -25
- Misses 8963 8997 +34
Continue to review full report at Codecov.
|
Benchmark for 1e5beb4Click to view benchmark
|
jedel1043
force-pushed
the
intrinsics-rewrite
branch
from
1284d2a to
8e1aa3d
Compare
Benchmark for 6995448Click to view benchmark
|
Benchmark for fea3e93Click to view benchmark
|
HalidOdat
reviewed
Mar 4, 2022
HalidOdat
approved these changes
Mar 4, 2022
raskad
reviewed
Mar 4, 2022
raskad
approved these changes
Mar 4, 2022
jedel1043
force-pushed
the
intrinsics-rewrite
branch
from
8030e2a to
900a14d
Compare
Benchmark for dae0362Click to view benchmark
|
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 4, 2022
Building up to #186, this PR extracts an `Intrinsics` struct from `Context`, facilitating a lot the extraction of a `Realm` struct. Also, it adapts the `BuiltIn` trait to be useful for builtins that don't expose a global property on initialization (`Generator`, `TypedArray`, etc.) It changes the following: - Creates an `Intrinsics` struct and refactors `Context` to transfer its intrinsic related fields to `Intrinsics`. - Renames some methods and parameters to better describe their functionality. - Makes `BuiltIn::init` return `Option<JsValue>` to skip global property initialization if the builtin initialization returns `None`
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Intrinsics struct from Context and cleanup namesIntrinsics struct from Context and cleanup names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building up to #186, this PR extracts an
Intrinsicsstruct fromContext, facilitating a lot the extraction of aRealmstruct.Also, it adapts the
BuiltIntrait to be useful for builtins that don't expose a global property on initialization (Generator,TypedArray, etc.)It changes the following:
Intrinsicsstruct and refactorsContextto transfer its intrinsic related fields toIntrinsics.BuiltIn::initreturnOption<JsValue>to skip global property initialization if the builtin initialization returnsNone