Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Continue panic fixes #1896

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Continue panic fixes #1896

wants to merge 3 commits into from

Conversation

addisoncrump
Copy link
Contributor

This PR changes the following:

  • Fixes the panics induced by incorrect continues.
  • Adds tests which demonstrate the various panics induced.
  • Actually rustfmts correctly?

@codecov
Copy link

codecov bot commented Mar 6, 2022 •
edited
Loading

Codecov Report

Merging #1896 (ec87038) into main (3b53fec) will decrease coverage by 0.02%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1896      +/-   ##
==========================================
- Coverage   46.41%   46.39%   -0.03%     
==========================================
  Files         206      206              
  Lines       16790    16800      +10     
==========================================
+ Hits         7793     7794       +1     
- Misses       8997     9006       +9
Impacted Files Coverage Δ
boa_engine/src/bytecompiler.rs 38.86% <61.53%> (+<0.01%) ⬆️
boa_engine/src/environments/compile.rs 39.82% <0.00%> (-2.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b53fec...ec87038. Read the comment docs.

@raskad raskad added bug Something isn't working vm Issues and PRs related to the Boa Virtual Machine. labels Mar 6, 2022
@raskad raskad added this to the v0.14.0 milestone Mar 6, 2022
@raskad
Copy link
Member

raskad commented Mar 6, 2022

VM implementation

Test result main count PR count difference
Total 88,342 88,342 0
Passed 43,291 43,291 0
Ignored 21,413 21,413 0
Failed 23,638 23,638 0
Panics 0 0 0
Conformance 49.00% 49.00% 0.00%

jedel1043
jedel1043 approved these changes Mar 6, 2022
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Mar 6, 2022
@addisoncrump
Continue panic fixes (#1896)
cc755db 
This PR changes the following:

- Fixes the panics induced by incorrect continues.
- Adds tests which demonstrate the various panics induced.
- Actually rustfmts correctly?
@bors
Copy link

bors bot commented Mar 6, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Continue panic fixes [Merged by Bors] - Continue panic fixes Mar 6, 2022
@bors bors bot closed this Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@raskad raskad raskad approved these changes

@Razican Razican Awaiting requested review from Razican

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@RageKnify RageKnify Awaiting requested review from RageKnify

Assignees
No one assigned
Labels
bug Something isn't working vm Issues and PRs related to the Boa Virtual Machine.
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@addisoncrump @raskad @jedel1043