[Merged by Bors] - convert inner datetime to local in to_date_string
#1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Date.prototype.toDateString` should return a value representing the local date. The Rust `Date` inner value represents UTC time, so it should be adjusted to local time before formatting (see `to_string` and `to_time_string`).
Razican
added
bug
Codecov Report
@@ Coverage Diff @@
## main #1953 +/- ##
=======================================
Coverage 45.87% 45.87%
=======================================
Files 206 206
Lines 17102 17102
=======================================
Hits 7846 7846
Misses 9256 9256
Continue to review full report at Codecov.
|
Razican
approved these changes
Mar 17, 2022
Razican
requested review from
raskad,
HalidOdat,
jasonwilliams,
jedel1043 and
RageKnify
RageKnify
approved these changes
Mar 17, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 17, 2022
This Pull Request fixes/closes #1942. `Date.prototype.toDateString` should return a value representing the local date. The Rust `Date` inner value represents UTC time, so it should be adjusted to local time before formatting (see equivalent conversions performed by `to_string` and `to_time_string`). To verify this is working as intended, run the test suite with your OS timezone set to `GMT+0`, then again with `GMT+10`. The test `date_proto_to_date_string` should pass for each. For me (Ubuntu via WSL), this can be done with `sudo dpkg-reconfigure tzdata`. This PR also fixes a couple other test cases that used the wrong month value (as noted at the top of the file, JS months are 0-based while `chrono` months are 1-based).
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
to_date_stringto_date_string
Razican
pushed a commit
that referenced
this pull request
Jun 8, 2022
This Pull Request fixes/closes #1942. `Date.prototype.toDateString` should return a value representing the local date. The Rust `Date` inner value represents UTC time, so it should be adjusted to local time before formatting (see equivalent conversions performed by `to_string` and `to_time_string`). To verify this is working as intended, run the test suite with your OS timezone set to `GMT+0`, then again with `GMT+10`. The test `date_proto_to_date_string` should pass for each. For me (Ubuntu via WSL), this can be done with `sudo dpkg-reconfigure tzdata`. This PR also fixes a couple other test cases that used the wrong month value (as noted at the top of the file, JS months are 0-based while `chrono` months are 1-based).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #1942.
Date.prototype.toDateStringshould return a value representing the local date. The RustDateinner value represents UTC time, so it should be adjusted to local time before formatting (see equivalent conversions performed byto_stringandto_time_string).To verify this is working as intended, run the test suite with your OS timezone set to
GMT+0, then again withGMT+10. The testdate_proto_to_date_stringshould pass for each. For me (Ubuntu via WSL), this can be done withsudo dpkg-reconfigure tzdata.This PR also fixes a couple other test cases that used the wrong month value (as noted at the top of the file, JS months are 0-based while
chronomonths are 1-based).