Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Support numbers with multiple leading zeroes #1979

Closed
wants to merge 1 commit into from

Conversation

lupd
Copy link
Contributor

@lupd lupd commented Mar 27, 2022

This Pull Request makes the non-octal-decimal-integer test pass. The test would previously fail for values with multiple leading zeroes.

It changes the following:

  • Number lexer

@codecov
Copy link

codecov bot commented Mar 27, 2022

Codecov Report

Merging #1979 (d528d16) into main (3f3f0aa) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main    #1979   +/-   ##
=======================================
  Coverage   45.93%   45.93%           
=======================================
  Files         206      206           
  Lines       17136    17138    +2     
=======================================
+ Hits         7871     7873    +2     
  Misses       9265     9265           
Impacted Files Coverage Δ
boa_engine/src/syntax/lexer/number.rs 50.58% <66.66%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f3f0aa...d528d16. Read the comment docs.

@Razican
Copy link
Member

Razican commented Mar 27, 2022

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 88,428 88,428 0
Passed 43,990 43,991 +1
Ignored 21,495 21,495 0
Failed 22,943 22,942 -1
Panics 0 0 0
Conformance 49.75% 49.75% +0.00%
Fixed tests (1):
test/language/literals/numeric/non-octal-decimal-integer.js (previously Failed)

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :)

@Razican Razican added bug Something isn't working lexer Issues surrounding the lexer labels Mar 27, 2022
@Razican Razican added this to the v0.15.0 milestone Mar 27, 2022
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@raskad
Copy link
Member

raskad commented Mar 27, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 27, 2022
This Pull Request makes the non-octal-decimal-integer test pass. The test would previously fail for values with multiple leading zeroes.

It changes the following:

- Number lexer
@bors
Copy link

bors bot commented Mar 27, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Support numbers with multiple leading zeroes [Merged by Bors] - Support numbers with multiple leading zeroes Mar 27, 2022
@bors bors bot closed this Mar 27, 2022
@lupd lupd deleted the non-octal-decimal-integer branch March 27, 2022 20:45
Razican pushed a commit that referenced this pull request Jun 8, 2022
This Pull Request makes the non-octal-decimal-integer test pass. The test would previously fail for values with multiple leading zeroes.

It changes the following:

- Number lexer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lexer Issues surrounding the lexer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants