-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Support numbers with multiple leading zeroes #1979
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1979 +/- ##
=======================================
Coverage 45.93% 45.93%
=======================================
Files 206 206
Lines 17136 17138 +2
=======================================
+ Hits 7871 7873 +2
Misses 9265 9265
Continue to review full report at Codecov.
|
Test262 conformance changesVM implementation
Fixed tests (1):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find!
bors r+ |
This Pull Request makes the non-octal-decimal-integer test pass. The test would previously fail for values with multiple leading zeroes. It changes the following: - Number lexer
Pull request successfully merged into main. Build succeeded: |
This Pull Request makes the non-octal-decimal-integer test pass. The test would previously fail for values with multiple leading zeroes. It changes the following: - Number lexer
This Pull Request makes the non-octal-decimal-integer test pass. The test would previously fail for values with multiple leading zeroes.
It changes the following: