[Merged by Bors] - fix(vm): off-by-one in code block stringification. #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call to retrieve operands modifies pc, setting it to the index of the *next* instruction. So, we save its initial value and use that for printing. Acked-by: Taylor Sutton <tsutton125@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1999 +/- ##
==========================================
- Coverage 45.90% 45.90% -0.01%
==========================================
Files 206 206
Lines 17148 17148
==========================================
- Hits 7872 7871 -1
- Misses 9276 9277 +1
Continue to review full report at Codecov.
|
raskad
requested review from
raskad,
Razican,
HalidOdat,
jasonwilliams,
jedel1043 and
RageKnify
raskad
approved these changes
Apr 2, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 2, 2022
Acked-by: Taylor Sutton <tsutton125@gmail.com> This Pull Request fixes/closes #1998 The call to retrieve operands modifies pc, setting it to the index of the *next* instruction. So, we save its initial value and use that for printing.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Razican
pushed a commit
that referenced
this pull request
Jun 8, 2022
Acked-by: Taylor Sutton <tsutton125@gmail.com> This Pull Request fixes/closes #1998 The call to retrieve operands modifies pc, setting it to the index of the *next* instruction. So, we save its initial value and use that for printing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acked-by: Taylor Sutton tsutton125@gmail.com
This Pull Request fixes/closes #1998
The call to retrieve operands modifies pc, setting it to the index of
the next instruction. So, we save its initial value and use that
for printing.