-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Allow Initializer
after ArrayBindingPattern
in FormalParameter
#2002
Conversation
VM implementation
Fixed tests (1868):
|
Codecov Report
@@ Coverage Diff @@
## main #2002 +/- ##
==========================================
- Coverage 43.99% 43.96% -0.03%
==========================================
Files 211 211
Lines 18665 18677 +12
==========================================
Hits 8211 8211
- Misses 10454 10466 +12
Continue to review full report at Codecov.
|
Benchmark for 0c9582dClick to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :)
Benchmark for f8b4951Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! And the test results are incredibly good! Thanks :)
bors r+ |
…2002) This Pull Request changes the following: - Allow `Initializer` after `ArrayBindingPattern` in `FormalParameter` - Refactor `Initializer` detection in `FormalParameter` to avoid clones
Pull request successfully merged into main. Build succeeded: |
Initializer
after ArrayBindingPattern
in FormalParameter
Initializer
after ArrayBindingPattern
in FormalParameter
…2002) This Pull Request changes the following: - Allow `Initializer` after `ArrayBindingPattern` in `FormalParameter` - Refactor `Initializer` detection in `FormalParameter` to avoid clones
This Pull Request changes the following:
Initializer
afterArrayBindingPattern
inFormalParameter
Initializer
detection inFormalParameter
to avoid clones