[Merged by Bors] - Feature JsFunction
#2015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
requested review from
jedel1043,
Razican,
jasonwilliams,
RageKnify and
raskad
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #2015 +/- ##
==========================================
- Coverage 43.86% 43.85% -0.02%
==========================================
Files 212 213 +1
Lines 18758 18767 +9
==========================================
+ Hits 8229 8231 +2
- Misses 10529 10536 +7
Continue to review full report at Codecov.
|
Benchmark for e45f1fdClick to view benchmark
|
HalidOdat
force-pushed
the
feature/jsfunction
branch
from
6673621 to
47fbfba
Compare
Benchmark for 396ad57Click to view benchmark
|
HalidOdat
force-pushed
the
feature/jsfunction
branch
from
47fbfba to
1396564
Compare
Benchmark for 7efac74Click to view benchmark
|
HalidOdat
force-pushed
the
feature/jsfunction
branch
from
1396564 to
2e236a1
Compare
Benchmark for 3b74e5dClick to view benchmark
|
Razican
reviewed
Apr 17, 2022
HalidOdat
force-pushed
the
feature/jsfunction
branch
from
2e236a1 to
452a91f
Compare
HalidOdat
force-pushed
the
feature/jsfunction
branch
from
452a91f to
257097b
Compare
Benchmark for 3af59f7Click to view benchmark
|
Razican
approved these changes
Apr 26, 2022
raskad
approved these changes
May 1, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 1, 2022
This PR adds `JsFunction` wrapper around JavaScript `Function` object, like #1746 With this PR we can distinguish between regular object and function object when we need, such as accessors (because they always need to be functions), predicates in `JsArray` methods like `map`, `find`, etc. With this abstraction we leverage the type system of rust which cleans the API making intentions clear. It changes the following: - Make methods that take predicate/callback function take `JsFunction`s - Make `.accessor()` and `.static_accessor()` take `Option<JsFunction>` - Make `FunctionBuilder` return `JsFunction` - Make `ConstructorBuilder` return `JsFunction` - Make `ClassBuilder` return `JsFunction`
|
Pull request successfully merged into main. Build succeeded: |
16 tasks
Razican
pushed a commit
that referenced
this pull request
Jun 8, 2022
This PR adds `JsFunction` wrapper around JavaScript `Function` object, like #1746 With this PR we can distinguish between regular object and function object when we need, such as accessors (because they always need to be functions), predicates in `JsArray` methods like `map`, `find`, etc. With this abstraction we leverage the type system of rust which cleans the API making intentions clear. It changes the following: - Make methods that take predicate/callback function take `JsFunction`s - Make `.accessor()` and `.static_accessor()` take `Option<JsFunction>` - Make `FunctionBuilder` return `JsFunction` - Make `ConstructorBuilder` return `JsFunction` - Make `ClassBuilder` return `JsFunction`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
JsFunctionwrapper around JavaScriptFunctionobject, like #1746With this PR we can distinguish between regular object and function object when we need, such as accessors (because they always need to be functions), predicates in
JsArraymethods likemap,find, etc. With this abstraction we leverage the type system of rust which cleans the API making intentions clear.It changes the following:
JsFunctions.accessor()and.static_accessor()takeOption<JsFunction>FunctionBuilderreturnJsFunctionConstructorBuilderreturnJsFunctionClassBuilderreturnJsFunction