-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Implement ProxyBuilder
#2076
Conversation
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #2076 +/- ##
==========================================
- Coverage 44.17% 44.17% -0.01%
==========================================
Files 215 216 +1
Lines 19371 19379 +8
==========================================
+ Hits 8558 8561 +3
- Misses 10813 10818 +5
Continue to review full report at Codecov.
|
Benchmark for ccd1624Click to view benchmark
|
Benchmark for 1686740Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. I like the builder approach.
Should we align this new public api with the existing ones in boa_engine/src/object/
like JsArray
, JsFunction
, etc.? If not, we basically have an additional kind of public api right?
Yeah, I can do that. It won't have any methods since |
Done! Will wait for #2079 to be merged, since that PR fixed the lints. |
Benchmark for 1dcbf80Click to view benchmark
|
Benchmark for f0f7f87Click to view benchmark
|
bors r+ |
Pull request successfully merged into main. Build succeeded: |
ProxyBuilder
ProxyBuilder
This Pull Request fixes/closes #2075.
It changes the following:
ProxyBuilder
struct to be able to createProxy
objects from native function traps.ProxyBuilder
and adjusts some documentation.