Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fixing build for changes in clippy for Rust 1.61 #2082

Closed
wants to merge 1 commit into from

Conversation

Razican
Copy link
Member

@Razican Razican commented May 20, 2022

This fixes the CI after the upgrade to Rust 1.61. I had to "allow" the use_self lint, due to rust-lang/rust-clippy#8845 and rust-lang/rust-clippy#6902.

It removed some false negatives, though, so I fixed some of the usage.

@Razican Razican added the Internal Category for changelog label May 20, 2022
@Razican Razican added this to the v0.15.0 milestone May 20, 2022
@raskad
Copy link
Member

raskad commented May 20, 2022

Probably the same as #2079?

@jedel1043
Copy link
Member

Probably the same as #2079?

Yep, but I would prefer having both separated. I just fixed it since it was throwing errors, I can rebase over this PR

@github-actions
Copy link

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 90,192 90,192 0
Passed 54,651 54,651 0
Ignored 23,279 23,279 0
Failed 12,262 12,262 0
Panics 0 0 0
Conformance 60.59% 60.59% 0.00%

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #2082 (3e8493c) into main (f3db18f) will increase coverage by 0.07%.
The diff coverage is 41.93%.

@@            Coverage Diff             @@
##             main    #2082      +/-   ##
==========================================
+ Coverage   44.10%   44.17%   +0.07%     
==========================================
  Files         215      215              
  Lines       19368    19371       +3     
==========================================
+ Hits         8542     8558      +16     
+ Misses      10826    10813      -13     
Impacted Files Coverage Δ
boa_engine/src/builtins/typed_array/mod.rs 3.73% <0.00%> (+0.08%) ⬆️
boa_engine/src/lib.rs 87.09% <ø> (+7.78%) ⬆️
boa_engine/src/syntax/ast/keyword.rs 95.91% <ø> (ø)
boa_engine/src/syntax/ast/node/declaration/mod.rs 50.00% <0.00%> (ø)
boa_engine/src/vm/opcode.rs 50.00% <ø> (ø)
boa_tester/src/main.rs 0.00% <ø> (ø)
boa_engine/src/value/mod.rs 52.53% <91.66%> (+0.15%) ⬆️
boa_engine/src/value/equality.rs 90.24% <100.00%> (ø)
boa_engine/src/value/integer.rs 62.50% <100.00%> (ø)
boa_engine/src/builtins/nan/mod.rs 33.33% <0.00%> (-16.67%) ⬇️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3db18f...3e8493c. Read the comment docs.

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request May 20, 2022
This fixes the CI after the upgrade to Rust 1.61. I had to "allow" the `use_self` lint, due to rust-lang/rust-clippy#8845 and rust-lang/rust-clippy#6902.

It removed some false negatives, though, so I fixed some of the usage.
@github-actions
Copy link

Benchmark for ec07449

Click to view benchmark
Test Base PR %
Arithmetic operations (Compiler) 542.7±1.31ns 540.6±2.52ns -0.39%
Arithmetic operations (Execution) 702.4±0.48ns 694.8±0.74ns -1.08%
Arithmetic operations (Parser) 6.3±0.01µs 6.3±0.01µs 0.00%
Array access (Compiler) 1499.2±2.00ns 1492.6±5.54ns -0.44%
Array access (Execution) 8.4±0.03µs 8.6±0.03µs +2.38%
Array access (Parser) 13.5±0.02µs 13.5±0.03µs 0.00%
Array creation (Compiler) 2.3±0.01µs 2.3±0.01µs 0.00%
Array creation (Execution) 2.6±0.01ms 2.6±0.00ms 0.00%
Array creation (Parser) 15.4±0.01µs 15.3±0.03µs -0.65%
Array pop (Compiler) 4.2±0.01µs 4.1±0.01µs -2.38%
Array pop (Execution) 1168.2±4.45µs 1163.0±5.30µs -0.45%
Array pop (Parser) 155.8±0.08µs 157.5±0.13µs +1.09%
Boolean Object Access (Compiler) 1161.3±4.77ns 1150.5±5.40ns -0.93%
Boolean Object Access (Execution) 4.3±0.01µs 4.3±0.05µs 0.00%
Boolean Object Access (Parser) 15.9±0.35µs 15.9±0.02µs 0.00%
Clean js (Compiler) 4.8±0.01µs 4.9±0.02µs +2.08%
Clean js (Execution) 727.4±5.30µs 722.3±4.32µs -0.70%
Clean js (Parser) 33.4±0.07µs 33.4±0.07µs 0.00%
Create Realm 279.3±0.25ns 278.7±10.90ns -0.21%
Dynamic Object Property Access (Compiler) 1898.4±6.12ns 1847.1±8.77ns -2.70%
Dynamic Object Property Access (Execution) 5.7±0.01µs 5.8±0.03µs +1.75%
Dynamic Object Property Access (Parser) 12.0±0.09µs 11.9±0.02µs -0.83%
Fibonacci (Compiler) 2.7±0.00µs 2.7±0.01µs 0.00%
Fibonacci (Execution) 1398.5±3.04µs 1423.5±3.27µs +1.79%
Fibonacci (Parser) 18.0±0.02µs 18.1±0.02µs +0.56%
For loop (Compiler) 2.6±0.01µs 2.6±0.01µs 0.00%
For loop (Execution) 16.9±0.05µs 16.5±0.05µs -2.37%
For loop (Parser) 15.9±0.02µs 15.9±0.02µs 0.00%
Mini js (Compiler) 4.2±0.02µs 4.3±0.01µs +2.38%
Mini js (Execution) 684.1±6.02µs 677.5±5.08µs -0.96%
Mini js (Parser) 29.3±0.03µs 29.3±0.03µs 0.00%
Number Object Access (Compiler) 1088.1±2.03ns 1075.2±1.99ns -1.19%
Number Object Access (Execution) 3.4±0.01µs 3.3±0.01µs -2.94%
Number Object Access (Parser) 12.4±0.02µs 12.4±0.02µs 0.00%
Object Creation (Compiler) 1650.2±5.09ns 1614.9±4.89ns -2.14%
Object Creation (Execution) 5.4±0.01µs 5.5±0.18µs +1.85%
Object Creation (Parser) 10.3±0.02µs 10.3±0.02µs 0.00%
RegExp (Compiler) 1863.8±8.41ns 1807.5±11.64ns -3.02%
RegExp (Execution) 12.3±0.07µs 12.8±0.10µs +4.07%
RegExp (Parser) 11.3±0.02µs 11.3±0.02µs 0.00%
RegExp Creation (Compiler) 1618.9±3.75ns 1613.7±5.61ns -0.32%
RegExp Creation (Execution) 9.3±0.04µs 9.7±0.03µs +4.30%
RegExp Creation (Parser) 9.4±0.02µs 9.4±0.02µs 0.00%
RegExp Literal (Compiler) 1848.5±8.67ns 1826.2±7.09ns -1.21%
RegExp Literal (Execution) 12.2±0.07µs 12.7±0.11µs +4.10%
RegExp Literal (Parser) 9.3±0.01µs 9.3±0.02µs 0.00%
RegExp Literal Creation (Compiler) 1636.8±2.84ns 1637.8±4.09ns +0.06%
RegExp Literal Creation (Execution) 9.3±0.05µs 9.8±0.03µs +5.38%
RegExp Literal Creation (Parser) 7.3±0.02µs 7.2±0.03µs -1.37%
Static Object Property Access (Compiler) 1643.2±4.18ns 1658.5±5.33ns +0.93%
Static Object Property Access (Execution) 5.5±0.01µs 5.6±0.01µs +1.82%
Static Object Property Access (Parser) 11.1±0.02µs 11.0±0.02µs -0.90%
String Object Access (Compiler) 1521.2±3.92ns 1536.9±6.53ns +1.03%
String Object Access (Execution) 6.4±0.04µs 6.4±0.03µs 0.00%
String Object Access (Parser) 15.6±0.03µs 15.6±0.04µs 0.00%
String comparison (Compiler) 2.3±0.01µs 2.3±0.01µs 0.00%
String comparison (Execution) 4.8±0.03µs 4.9±0.02µs +2.08%
String comparison (Parser) 12.3±0.07µs 12.3±0.06µs 0.00%
String concatenation (Compiler) 1858.4±7.38ns 1834.4±7.50ns -1.29%
String concatenation (Execution) 4.6±0.01µs 4.7±0.03µs +2.17%
String concatenation (Parser) 8.6±0.03µs 8.5±0.04µs -1.16%
String copy (Compiler) 1541.1±6.95ns 1512.1±8.37ns -1.88%
String copy (Execution) 4.3±0.01µs 4.4±0.02µs +2.33%
String copy (Parser) 6.4±0.02µs 6.4±0.01µs 0.00%
Symbols (Compiler) 1128.4±4.48ns 1129.5±3.36ns +0.10%
Symbols (Execution) 4.4±0.01µs 4.5±0.01µs +2.27%
Symbols (Parser) 5.0±0.01µs 4.9±0.01µs -2.00%

@bors
Copy link

bors bot commented May 20, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fixing build for changes in clippy for Rust 1.61 [Merged by Bors] - Fixing build for changes in clippy for Rust 1.61 May 20, 2022
@bors bors bot closed this May 20, 2022
@bors bors bot deleted the rust_1_61 branch May 20, 2022 21:55
Razican added a commit that referenced this pull request Jun 8, 2022
This fixes the CI after the upgrade to Rust 1.61. I had to "allow" the `use_self` lint, due to rust-lang/rust-clippy#8845 and rust-lang/rust-clippy#6902.

It removed some false negatives, though, so I fixed some of the usage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants