-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fixing build for changes in clippy for Rust 1.61 #2082
Conversation
Probably the same as #2079? |
Yep, but I would prefer having both separated. I just fixed it since it was throwing errors, I can rebase over this PR |
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #2082 +/- ##
==========================================
+ Coverage 44.10% 44.17% +0.07%
==========================================
Files 215 215
Lines 19368 19371 +3
==========================================
+ Hits 8542 8558 +16
+ Misses 10826 10813 -13
Continue to review full report at Codecov.
|
bors r+ |
This fixes the CI after the upgrade to Rust 1.61. I had to "allow" the `use_self` lint, due to rust-lang/rust-clippy#8845 and rust-lang/rust-clippy#6902. It removed some false negatives, though, so I fixed some of the usage.
Benchmark for ec07449Click to view benchmark
|
Pull request successfully merged into main. Build succeeded: |
This fixes the CI after the upgrade to Rust 1.61. I had to "allow" the `use_self` lint, due to rust-lang/rust-clippy#8845 and rust-lang/rust-clippy#6902. It removed some false negatives, though, so I fixed some of the usage.
This fixes the CI after the upgrade to Rust 1.61. I had to "allow" the
use_self
lint, due to rust-lang/rust-clippy#8845 and rust-lang/rust-clippy#6902.It removed some false negatives, though, so I fixed some of the usage.