Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix spec links for some object operation methods #2111

Closed
wants to merge 1 commit into from

Conversation

CYBAI
Copy link
Contributor

@CYBAI CYBAI commented Jun 11, 2022

It changes the following:

Fix spec links for

  • create_data_property
  • create_data_property_or_throw
  • delete_property_or_throw

@raskad raskad added this to the v0.16.0 milestone Jun 11, 2022
@raskad raskad added documentation update documentation Internal Category for changelog labels Jun 11, 2022
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #2111 (3ce95ec) into main (0eb771d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2111   +/-   ##
=======================================
  Coverage   43.64%   43.64%           
=======================================
  Files         217      217           
  Lines       19656    19656           
=======================================
  Hits         8578     8578           
  Misses      11078    11078           
Impacted Files Coverage Δ
boa_engine/src/object/operations.rs 60.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eb771d...3ce95ec. Read the comment docs.

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jun 11, 2022
It changes the following:

Fix spec links for 
- `create_data_property`
- `create_data_property_or_throw`
- `delete_property_or_throw`
@bors
Copy link

bors bot commented Jun 11, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix spec links for some object operation methods [Merged by Bors] - Fix spec links for some object operation methods Jun 11, 2022
@bors bors bot closed this Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation update documentation Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants