Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix eval attributes #2130

Closed
wants to merge 1 commit into from
Closed

Conversation

raskad
Copy link
Member

@raskad raskad commented Jun 19, 2022

This Pull Request changes the following:

  • Fix eval attributes
  • Fix eval length
  • Fix eval name

@raskad raskad added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Jun 19, 2022
@raskad raskad added this to the v0.16.0 milestone Jun 19, 2022
@github-actions
Copy link

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 90,619 90,619 0
Passed 56,859 56,877 +18
Ignored 13,788 13,788 0
Failed 19,972 19,954 -18
Panics 0 0 0
Conformance 62.75% 62.76% +0.02%
Fixed tests (18):
test/language/statements/for-of/dstr/obj-id-simple-no-strict.js (previously Failed)
test/language/statements/for-of/dstr/array-elem-init-simple-no-strict.js (previously Failed)
test/language/statements/for-of/dstr/array-elem-target-simple-no-strict.js (previously Failed)
test/language/expressions/assignment/dstr/obj-id-simple-no-strict.js (previously Failed)
test/language/expressions/assignment/dstr/array-elem-init-simple-no-strict.js (previously Failed)
test/language/expressions/assignment/dstr/array-elem-target-simple-no-strict.js (previously Failed)
test/built-ins/Object/getOwnPropertyDescriptor/15.2.3.3-4-4.js [strict mode] (previously Failed)
test/built-ins/Object/getOwnPropertyDescriptor/15.2.3.3-4-4.js (previously Failed)
test/built-ins/eval/length-non-writable.js [strict mode] (previously Failed)
test/built-ins/eval/length-non-writable.js (previously Failed)
test/built-ins/eval/prop-desc.js [strict mode] (previously Failed)
test/built-ins/eval/prop-desc.js (previously Failed)
test/built-ins/eval/length-value.js [strict mode] (previously Failed)
test/built-ins/eval/length-value.js (previously Failed)
test/built-ins/eval/name.js [strict mode] (previously Failed)
test/built-ins/eval/name.js (previously Failed)
test/built-ins/eval/length-non-configurable.js [strict mode] (previously Failed)
test/built-ins/eval/length-non-configurable.js (previously Failed)

@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #2130 (7b6a9a5) into main (d173e08) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2130   +/-   ##
=======================================
  Coverage   43.48%   43.48%           
=======================================
  Files         220      220           
  Lines       19983    19984    +1     
=======================================
+ Hits         8689     8690    +1     
  Misses      11294    11294           
Impacted Files Coverage Δ
boa_engine/src/builtins/eval/mod.rs 11.76% <100.00%> (+2.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d173e08...7b6a9a5. Read the comment docs.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@raskad
Copy link
Member Author

raskad commented Jun 20, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jun 20, 2022
This Pull Request changes the following:

- Fix `eval` attributes
- Fix `eval` length
- Fix `eval` name
@bors
Copy link

bors bot commented Jun 20, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix eval attributes [Merged by Bors] - Fix eval attributes Jun 20, 2022
@bors bors bot closed this Jun 20, 2022
@bors bors bot deleted the fix-eval-attributes branch June 20, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants