-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Implement Generator Function Constructor #2174
Conversation
Test262 conformance changesVM implementation
Fixed tests (30):
|
Codecov Report
@@ Coverage Diff @@
## main #2174 +/- ##
==========================================
- Coverage 41.90% 41.90% -0.01%
==========================================
Files 231 231
Lines 21502 21501 -1
==========================================
- Hits 9011 9010 -1
Misses 12491 12491
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a couple of questions, for clarifications mostly :) thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
bors r+ |
This Pull Request changes the following: - Modify `CreateDynamicFunction` to work with generator functions. - Add the name `anonymus` to functions created via `CreateDynamicFunction` to comply with the spec. - Fix a bug in the `Yield` parser where the parser would expect a token when no token is a legal case. - Change the `Yield::new` function to require less turbofishes.
Pull request successfully merged into main. Build succeeded: |
This Pull Request changes the following:
CreateDynamicFunction
to work with generator functions.anonymus
to functions created viaCreateDynamicFunction
to comply with the spec.Yield
parser where the parser would expect a token when no token is a legal case.Yield::new
function to require less turbofishes.