[Merged by Bors] - Fix length/index in 32bit architectures
#2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
requested review from
Razican,
jasonwilliams,
RageKnify,
raskad and
jedel1043
HalidOdat
force-pushed
the
fix/32bit-length
branch
from
71a1603 to
09ee089
Compare
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #2196 +/- ##
==========================================
- Coverage 41.93% 41.92% -0.02%
==========================================
Files 231 231
Lines 21498 21499 +1
==========================================
- Hits 9015 9013 -2
- Misses 12483 12486 +3
Continue to review full report at Codecov.
|
raskad
approved these changes
Jul 21, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 21, 2022
This PR fixes the length/index types from `usize` to `u64`, because in JavaScript the length can be from `0` to `2^53 - 1` it cannot be represented in a `usize`. On `64-bit` architectures this is fine because it is already a unsigned 64bit number and these changes essentially do nothing. But on 32bit architectures this was causing the length to be truncated giving an unexpected result. fixes/closes #2182 It changes the following: - Make length a `u64` to be able to represent all possible length values - Change `JsValue::to_length()` t return `u64` - Change `JsValue::to_index()` t return `u64`
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
32bit architectures32bit architectures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the length/index types from
usizetou64, because in JavaScript the length can be from0to2^53 - 1it cannot be represented in ausize. On64-bitarchitectures this is fine because it is already a unsigned 64bit number and these changes essentially do nothing. But on 32bit architectures this was causing the length to be truncated giving an unexpected result.fixes/closes #2182
It changes the following:
u64to be able to represent all possible length valuesJsValue::to_length()t returnu64JsValue::to_index()t returnu64