Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README.md] Adjust headings importance and update Usage section #220

Merged
merged 4 commits into from
Jan 15, 2020

Conversation

croraf
Copy link
Contributor

@croraf croraf commented Jan 13, 2020

Adjust headings in readme file

@croraf croraf changed the title Readme minor fix Adjust headings in README.md Jan 13, 2020
@croraf croraf changed the title Adjust headings in README.md Adjust headings importance in README.md Jan 13, 2020
@croraf croraf changed the title Adjust headings importance in README.md [README.md] Adjust headings importance and update Usage section Jan 14, 2020
README.md Outdated
- `cargo run`
- You can make changes to tests/js/test.js and build again
- If any JS doesn't work then it's a bug! Please raise an issue
- Clone this repo and position yourself in its folder root
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that being in the root of the project is usually implied, so you can remove this

README.md Outdated
- You can make changes to tests/js/test.js and build again
- If any JS doesn't work then it's a bug! Please raise an issue
- Clone this repo and position yourself in its folder root
- Create a JS file that will be executed, for example `test.js`, and fill it with some JS code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, you can change this to something like

Suggested change
- Create a JS file that will be executed, for example `test.js`, and fill it with some JS code
- Run with `cargo run -- test.js`, where `test.js` is an existing JS file

@IovoslavIovchev IovoslavIovchev merged commit b57856c into boa-dev:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants