[Merged by Bors] - Removed some unsafe_empty_trace!() calls to improve performance #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
added
performance
Razican
requested review from
raskad,
jedel1043,
HalidOdat,
jasonwilliams and
RageKnify
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #2233 +/- ##
==========================================
- Coverage 41.35% 41.32% -0.04%
==========================================
Files 234 234
Lines 22009 22023 +14
==========================================
- Hits 9101 9100 -1
- Misses 12908 12923 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
raskad
approved these changes
Aug 13, 2022
Benchmark for 3a3a607Click to view benchmark
|
HalidOdat
approved these changes
Aug 14, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2022
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel neccesary. ---> This Pull Request fixes #1615. It changes the following: - Removes the `Trace` implementation from types that don't need it (except for `JsSymbol` and `JsString`, which are needed elsewere). - Uses `#[unsafe_ignore_trace]` in places where we need to implement `Trace` for part of a structure. - Implements a custom `Trace` in enums where deriving it is not possible, since `#[unsafe_ignore_trace]` doesn't work for enums.
|
Build failed: |
|
Bors retry |
bors bot
pushed a commit
that referenced
this pull request
Aug 15, 2022
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel neccesary. ---> This Pull Request fixes #1615. It changes the following: - Removes the `Trace` implementation from types that don't need it (except for `JsSymbol` and `JsString`, which are needed elsewere). - Uses `#[unsafe_ignore_trace]` in places where we need to implement `Trace` for part of a structure. - Implements a custom `Trace` in enums where deriving it is not possible, since `#[unsafe_ignore_trace]` doesn't work for enums.
|
Build failed: |
Benchmark for 9e4a166Click to view benchmark
|
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 17, 2022
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel neccesary. ---> This Pull Request fixes #1615. It changes the following: - Removes the `Trace` implementation from types that don't need it (except for `JsSymbol` and `JsString`, which are needed elsewere). - Uses `#[unsafe_ignore_trace]` in places where we need to implement `Trace` for part of a structure. - Implements a custom `Trace` in enums where deriving it is not possible, since `#[unsafe_ignore_trace]` doesn't work for enums. Co-authored-by: raskad <32105367+raskad@users.noreply.github.com>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes #1615.
It changes the following:
Traceimplementation from types that don't need it (except forJsSymbolandJsString, which are needed elsewere).#[unsafe_ignore_trace]in places where we need to implementTracefor part of a structure.Tracein enums where deriving it is not possible, since#[unsafe_ignore_trace]doesn't work for enums.