-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Implement JsDataView
#2308
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2308 +/- ##
==========================================
- Coverage 41.19% 40.93% -0.27%
==========================================
Files 237 238 +1
Lines 22375 22509 +134
==========================================
- Hits 9218 9214 -4
- Misses 13157 13295 +138
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! It looks very good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed some typos and rewrote some expressions into a simpler form. Thank you for the contribution!
bors r+ |
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel necessary. ---> This Pull Request is related to #2098 . It changes the following: - Implements a wrapper for `DataView` - Adds an example of `JsDataView` to the `JsArrayBuffer` example file under boa_examples Co-authored-by: jedel1043 <jedel0124@gmail.com>
Pull request successfully merged into main. Build succeeded: |
This Pull Request is related to #2098 .
It changes the following:
DataView
JsDataView
to theJsArrayBuffer
example file under boa_examples