Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Implement JsDataView #2308

Closed
wants to merge 6 commits into from

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Sep 25, 2022

This Pull Request is related to #2098 .

It changes the following:

  • Implements a wrapper for DataView
  • Adds an example of JsDataView to the JsArrayBuffer example file under boa_examples

@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Merging #2308 (fda0ab9) into main (e9e85f5) will decrease coverage by 0.26%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2308      +/-   ##
==========================================
- Coverage   41.19%   40.93%   -0.27%     
==========================================
  Files         237      238       +1     
  Lines       22375    22509     +134     
==========================================
- Hits         9218     9214       -4     
- Misses      13157    13295     +138     
Impacted Files Coverage Δ
boa_engine/src/builtins/dataview/mod.rs 8.08% <ø> (ø)
boa_engine/src/object/jsdataview.rs 0.00% <0.00%> (ø)
boa_engine/src/object/mod.rs 20.55% <ø> (ø)
boa_engine/src/syntax/parser/expression/unary.rs 47.16% <0.00%> (-1.89%) ⬇️
boa_engine/src/builtins/array/mod.rs 73.60% <0.00%> (-1.32%) ⬇️
...a_engine/src/syntax/parser/statement/switch/mod.rs 38.37% <0.00%> (-1.17%) ⬇️
...arser/expression/primary/object_initializer/mod.rs 42.05% <0.00%> (-0.40%) ⬇️
.../statement/declaration/hoistable/class_decl/mod.rs 26.91% <0.00%> (-0.35%) ⬇️
boa_engine/src/builtins/mod.rs 11.59% <0.00%> (-0.18%) ⬇️
boa_engine/src/value/mod.rs 53.19% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jedel1043 jedel1043 added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics API labels Sep 25, 2022
@jedel1043 jedel1043 added this to the v0.17.0 milestone Sep 25, 2022
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! It looks very good :)

@Razican Razican added the hacktoberfest-accepted PR accepted for Hacktoberfest label Oct 2, 2022
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some typos and rewrote some expressions into a simpler form. Thank you for the contribution!

@jedel1043
Copy link
Member

bors r+

@bors
Copy link

bors bot commented Oct 2, 2022

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

bors bot pushed a commit that referenced this pull request Oct 2, 2022
<!---
Thank you for contributing to Boa! Please fill out the template below, and remove or add any
information as you feel necessary.
--->

This Pull Request is related to #2098 .

It changes the following:

- Implements a wrapper for `DataView`
- Adds an example of `JsDataView` to the `JsArrayBuffer` example file under boa_examples


Co-authored-by: jedel1043 <jedel0124@gmail.com>
@bors
Copy link

bors bot commented Oct 2, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement JsDataView [Merged by Bors] - Implement JsDataView Oct 2, 2022
@bors bors bot closed this Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request hacktoberfest-accepted PR accepted for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants