Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Parse static async private methods in classes #2315

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Parse static async private methods in classes #2315

wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Sep 28, 2022

This Pull Request changes the following:

  • Adjust AsyncMethod parsing to parse private identifiers.

@raskad raskad added enhancement New feature or request parser Issues surrounding the parser labels Sep 28, 2022
@raskad raskad added this to the v0.17.0 milestone Sep 28, 2022
@github-actions
Copy link

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 92,351 92,351 0
Passed 68,762 68,926 +164
Ignored 17,180 17,180 0
Failed 6,409 6,245 -,164
Panics 0 0 0
Conformance 74.46% 74.63% +0.18%
Fixed tests (164): 
test/language/expressions/class/elements/same-line-method-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/expressions/class/elements/same-line-method-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/expressions/class/elements/multiple-definitions-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/expressions/class/elements/multiple-definitions-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/expressions/class/elements/new-no-sc-line-method-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/expressions/class/elements/new-no-sc-line-method-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/expressions/class/elements/same-line-method-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/expressions/class/elements/same-line-method-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/expressions/class/elements/new-sc-line-gen-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/expressions/class/elements/new-sc-line-gen-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/expressions/class/elements/after-same-line-static-async-method-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/expressions/class/elements/after-same-line-static-async-method-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/expressions/class/elements/same-line-async-method-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/expressions/class/elements/same-line-async-method-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/expressions/class/elements/same-line-async-method-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/expressions/class/elements/same-line-async-method-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/expressions/class/elements/after-same-line-static-async-gen-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/expressions/class/elements/after-same-line-static-async-gen-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/expressions/class/elements/after-same-line-gen-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/expressions/class/elements/after-same-line-gen-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/expressions/class/elements/after-same-line-static-method-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/expressions/class/elements/after-same-line-static-method-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/expressions/class/elements/after-same-line-static-gen-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/expressions/class/elements/after-same-line-static-gen-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/expressions/class/elements/regular-definitions-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/expressions/class/elements/regular-definitions-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/expressions/class/elements/multiple-definitions-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/expressions/class/elements/multiple-definitions-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/expressions/class/elements/wrapped-in-sc-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/expressions/class/elements/wrapped-in-sc-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/expressions/class/elements/after-same-line-static-method-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/expressions/class/elements/after-same-line-static-method-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/expressions/class/elements/after-same-line-method-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/expressions/class/elements/after-same-line-method-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/expressions/class/elements/multiple-stacked-definitions-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/expressions/class/elements/multiple-stacked-definitions-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/expressions/class/elements/regular-definitions-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/expressions/class/elements/regular-definitions-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/expressions/class/elements/after-same-line-static-async-method-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/expressions/class/elements/after-same-line-static-async-method-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/expressions/class/elements/same-line-gen-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/expressions/class/elements/same-line-gen-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/expressions/class/elements/after-same-line-gen-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/expressions/class/elements/after-same-line-gen-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/expressions/class/elements/same-line-async-gen-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/expressions/class/elements/same-line-async-gen-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/expressions/class/elements/same-line-async-gen-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/expressions/class/elements/same-line-async-gen-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/expressions/class/elements/new-sc-line-method-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/expressions/class/elements/new-sc-line-method-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/expressions/class/elements/wrapped-in-sc-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/expressions/class/elements/wrapped-in-sc-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/expressions/class/elements/after-same-line-static-async-gen-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/expressions/class/elements/after-same-line-static-async-gen-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/expressions/class/elements/after-same-line-method-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/expressions/class/elements/after-same-line-method-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/expressions/class/elements/new-no-sc-line-method-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/expressions/class/elements/new-no-sc-line-method-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/expressions/class/elements/new-sc-line-method-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/expressions/class/elements/new-sc-line-method-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/expressions/class/elements/new-sc-line-gen-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/expressions/class/elements/new-sc-line-gen-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/expressions/class/elements/after-same-line-static-gen-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/expressions/class/elements/after-same-line-static-gen-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/expressions/class/elements/multiple-stacked-definitions-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/expressions/class/elements/multiple-stacked-definitions-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/expressions/class/elements/same-line-gen-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/expressions/class/elements/same-line-gen-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/expressions/class/elements/async-private-method/returns-async-function.js [strict mode] (previously Failed)
test/language/expressions/class/elements/async-private-method/returns-async-function.js (previously Failed)
test/language/expressions/class/elements/async-private-method/returns-async-function-returns-newtarget.js [strict mode] (previously Failed)
test/language/expressions/class/elements/async-private-method/returns-async-function-returns-newtarget.js (previously Failed)
test/language/expressions/class/elements/async-private-method/returns-async-function-returns-arguments-from-own-function.js [strict mode] (previously Failed)
test/language/expressions/class/elements/async-private-method/returns-async-function-returns-arguments-from-own-function.js (previously Failed)
test/language/expressions/class/elements/async-private-method-static/returns-async-function.js [strict mode] (previously Failed)
test/language/expressions/class/elements/async-private-method-static/returns-async-function.js (previously Failed)
test/language/expressions/class/elements/async-private-method-static/returns-async-function-returns-newtarget.js [strict mode] (previously Failed)
test/language/expressions/class/elements/async-private-method-static/returns-async-function-returns-newtarget.js (previously Failed)
test/language/expressions/class/elements/async-private-method-static/returns-async-function-returns-arguments-from-own-function.js [strict mode] (previously Failed)
test/language/expressions/class/elements/async-private-method-static/returns-async-function-returns-arguments-from-own-function.js (previously Failed)
test/language/expressions/class/elements/syntax/valid/grammar-static-private-async-meth-prototype.js [strict mode] (previously Failed)
test/language/expressions/class/elements/syntax/valid/grammar-static-private-async-meth-prototype.js (previously Failed)
test/language/statements/class/elements/same-line-method-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/statements/class/elements/same-line-method-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/statements/class/elements/multiple-definitions-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/statements/class/elements/multiple-definitions-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/statements/class/elements/new-no-sc-line-method-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/statements/class/elements/new-no-sc-line-method-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/statements/class/elements/same-line-method-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/statements/class/elements/same-line-method-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/statements/class/elements/new-sc-line-gen-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/statements/class/elements/new-sc-line-gen-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/statements/class/elements/after-same-line-static-async-method-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/statements/class/elements/after-same-line-static-async-method-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/statements/class/elements/same-line-async-method-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/statements/class/elements/same-line-async-method-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/statements/class/elements/same-line-async-method-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/statements/class/elements/same-line-async-method-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/statements/class/elements/after-same-line-static-async-gen-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/statements/class/elements/after-same-line-static-async-gen-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/statements/class/elements/after-same-line-gen-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/statements/class/elements/after-same-line-gen-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/statements/class/elements/after-same-line-static-method-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/statements/class/elements/after-same-line-static-method-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/statements/class/elements/after-same-line-static-gen-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/statements/class/elements/after-same-line-static-gen-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/statements/class/elements/regular-definitions-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/statements/class/elements/regular-definitions-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/statements/class/elements/multiple-definitions-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/statements/class/elements/multiple-definitions-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/statements/class/elements/wrapped-in-sc-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/statements/class/elements/wrapped-in-sc-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/statements/class/elements/after-same-line-static-method-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/statements/class/elements/after-same-line-static-method-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/statements/class/elements/after-same-line-method-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/statements/class/elements/after-same-line-method-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/statements/class/elements/multiple-stacked-definitions-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/statements/class/elements/multiple-stacked-definitions-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/statements/class/elements/regular-definitions-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/statements/class/elements/regular-definitions-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/statements/class/elements/after-same-line-static-async-method-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/statements/class/elements/after-same-line-static-async-method-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/statements/class/elements/same-line-gen-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/statements/class/elements/same-line-gen-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/statements/class/elements/after-same-line-gen-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/statements/class/elements/after-same-line-gen-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/statements/class/elements/same-line-async-gen-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/statements/class/elements/same-line-async-gen-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/statements/class/elements/same-line-async-gen-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/statements/class/elements/same-line-async-gen-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/statements/class/elements/new-sc-line-method-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/statements/class/elements/new-sc-line-method-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/statements/class/elements/wrapped-in-sc-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/statements/class/elements/wrapped-in-sc-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/statements/class/elements/after-same-line-static-async-gen-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/statements/class/elements/after-same-line-static-async-gen-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/statements/class/elements/after-same-line-method-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/statements/class/elements/after-same-line-method-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/statements/class/elements/new-no-sc-line-method-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/statements/class/elements/new-no-sc-line-method-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/statements/class/elements/new-sc-line-method-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/statements/class/elements/new-sc-line-method-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/statements/class/elements/new-sc-line-gen-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/statements/class/elements/new-sc-line-gen-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/statements/class/elements/after-same-line-static-gen-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/statements/class/elements/after-same-line-static-gen-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/statements/class/elements/multiple-stacked-definitions-rs-static-async-method-privatename-identifier.js [strict mode] (previously Failed)
test/language/statements/class/elements/multiple-stacked-definitions-rs-static-async-method-privatename-identifier.js (previously Failed)
test/language/statements/class/elements/same-line-gen-rs-static-async-method-privatename-identifier-alt.js [strict mode] (previously Failed)
test/language/statements/class/elements/same-line-gen-rs-static-async-method-privatename-identifier-alt.js (previously Failed)
test/language/statements/class/elements/async-private-method/returns-async-function.js [strict mode] (previously Failed)
test/language/statements/class/elements/async-private-method/returns-async-function.js (previously Failed)
test/language/statements/class/elements/async-private-method/returns-async-function-returns-newtarget.js [strict mode] (previously Failed)
test/language/statements/class/elements/async-private-method/returns-async-function-returns-newtarget.js (previously Failed)
test/language/statements/class/elements/async-private-method/returns-async-function-returns-arguments-from-own-function.js [strict mode] (previously Failed)
test/language/statements/class/elements/async-private-method/returns-async-function-returns-arguments-from-own-function.js (previously Failed)
test/language/statements/class/elements/async-private-method-static/returns-async-function.js [strict mode] (previously Failed)
test/language/statements/class/elements/async-private-method-static/returns-async-function.js (previously Failed)
test/language/statements/class/elements/async-private-method-static/returns-async-function-returns-newtarget.js [strict mode] (previously Failed)
test/language/statements/class/elements/async-private-method-static/returns-async-function-returns-newtarget.js (previously Failed)
test/language/statements/class/elements/async-private-method-static/returns-async-function-returns-arguments-from-own-function.js [strict mode] (previously Failed)
test/language/statements/class/elements/async-private-method-static/returns-async-function-returns-arguments-from-own-function.js (previously Failed)
test/language/statements/class/elements/syntax/valid/grammar-static-private-async-meth-prototype.js [strict mode] (previously Failed)
test/language/statements/class/elements/syntax/valid/grammar-static-private-async-meth-prototype.js (previously Failed)

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #2315 (7ad8072) into main (3e26910) will decrease coverage by 0.02%.
The diff coverage is 16.00%.

@@            Coverage Diff             @@
##             main    #2315      +/-   ##
==========================================
- Coverage   41.16%   41.14%   -0.03%     
==========================================
  Files         237      237              
  Lines       22378    22393      +15     
==========================================
+ Hits         9212     9213       +1     
- Misses      13166    13180      +14
Impacted Files Coverage Δ
.../statement/declaration/hoistable/class_decl/mod.rs 26.91% <0.00%> (-0.35%) ⬇️
...arser/expression/primary/object_initializer/mod.rs 42.05% <40.00%> (-0.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jedel1043
jedel1043 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Razican Razican added the hacktoberfest-accepted PR accepted for Hacktoberfest label Oct 2, 2022
Razican
Razican approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thank you :)

@Razican
Copy link
Member

Razican commented Oct 2, 2022

bors r+

bors bot pushed a commit that referenced this pull request Oct 2, 2022
@raskad
Parse static async private methods in classes (#2315)
7f1d1a9 
This Pull Request changes the following:

- Adjust `AsyncMethod` parsing to parse private identifiers.
@bors
Copy link

bors bot commented Oct 2, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Parse static async private methods in classes [Merged by Bors] - Parse static async private methods in classes Oct 2, 2022
@bors bors bot closed this Oct 2, 2022
@bors bors bot deleted the class-static-async-method branch October 2, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@Razican Razican Razican approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@RageKnify RageKnify Awaiting requested review from RageKnify

Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest-accepted PR accepted for Hacktoberfest parser Issues surrounding the parser
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @Razican @jedel1043