[Merged by Bors] - Separate JsObjectType implementors to their own module #2324
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## main #2324 +/- ##
=======================================
Coverage 40.93% 40.93%
=======================================
Files 238 238
Lines 22509 22509
=======================================
Hits 9214 9214
Misses 13295 13295
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@jedel1043 if you have time, could you review this PR? And is there anything else I should do? 😅 |
jedel1043
added
documentation
There was a problem hiding this comment.
Thank you! And sorry for the delay 😅. The PR looks good! However, I would lift JsObject to be inside the object module, since that's the main object users would interact with, and change js_object to something like builtins, just to clarify that these are wrappers for builtin objects.
Also, can you make the new module a proper directory? It would be very good to have the wrappers on a separate directory from the main object internals.
There was a problem hiding this comment.
Thank you! This looks good to me as soon as @jedel1043's proposal is implemented
CalliEve
requested review from
jedel1043
and removed request for
HalidOdat and
raskad
|
I implemented the changes requested by @jedel1043. Let me know if there's anything else I should do 😄 |
|
bors r+ |
This Pull Request closes #2080. It moves all implementors of the `JsObjectType` trait into their own `js_object` module. This should simplify documentation and by doing a `pub(crate)` export in `object` little to no imports within the crate need to be changed, simplifying the usage of this module within the boa_engine crate. Documentation within the `object` module has been updated to reflect this change and in a way that it is shown on the home page of the documentation.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
This Pull Request closes #2080.
It moves all implementors of the
JsObjectTypetrait into their ownjs_objectmodule.This should simplify documentation and by doing a
pub(crate)export inobjectlittle to no imports within the crate need to be changed, simplifying the usage of this module within the boa_engine crate.Documentation within the
objectmodule has been updated to reflect this change and in a way that it is shown on the home page of the documentation.