[Merged by Bors] - Modified the loadfile example to show how Boa can read bytes
#2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
added
enhancement
Razican
requested review from
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
jedel1043
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #2363 +/- ##
=======================================
Coverage 39.84% 39.84%
=======================================
Files 242 242
Lines 23242 23242
=======================================
Hits 9260 9260
Misses 13982 13982 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
HalidOdat
approved these changes
Oct 21, 2022
Currently no, since the lexer and the parser assume UTF-8. Though, this will change when we make them generic over chars/u32 instead. |
jedel1043
approved these changes
Oct 21, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2022
Boa's `Context::eval()` and `Context::parse()` functions allow reading a byte slice directly, apart from a string. We were not showing this properly in our examples, so this modifies the `loadfile.rs` example to use a byte vector instead of a string, which allows us to use UTF-16 files, if I'm not mistaken.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
loadfile example to show how Boa can read bytesloadfile example to show how Boa can read bytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boa's
Context::eval()andContext::parse()functions allow reading a byte slice directly, apart from a string. We were not showing this properly in our examples, so this modifies theloadfile.rsexample to use a byte vector instead of a string, which allows us to use UTF-16 files, if I'm not mistaken.