Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Updated the Code of Conduct #2365

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Updated the Code of Conduct #2365

wants to merge 2 commits into from

Conversation

Razican
Copy link
Member

@Razican Razican commented Oct 21, 2022

This updates the Code of Conduct to the Contributor Covenant v2.1 version (we were using the 2.0 version until now). Changes are very minor. As far as I can tell, the only content difference is the explicit mention of caste and color among the potential traits that could cause harassment.

Then it just changes the format a bit to make links a bit more user friendly, by not posting URLs directly.

But I have a question: should we update the contact method? It currently says the following:

Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to the community leaders responsible for enforcement at discord by contacting JaseW.

Maybe we should mention the @boa-dev group, and that they can contact anyone there. What do you think? I would also like to update this before boa-dev/ryu-js#22

@Razican Razican added help wanted Extra attention is needed discussion Issues needing more discussion labels Oct 21, 2022
@Razican Razican added this to the v0.17.0 milestone Oct 21, 2022
@github-actions
Copy link

github-actions bot commented Oct 21, 2022

Test262 conformance changes

Test result main count PR count difference
Total 93,383 93,383 0
Passed 69,114 69,114 0
Ignored 18,182 18,182 0
Failed 6,087 6,087 0
Panics 0 0 0
Conformance 74.01% 74.01% 0.00%

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #2365 (42746a4) into main (a47d9ec) will increase coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2365      +/-   ##
==========================================
+ Coverage   39.85%   40.05%   +0.20%     
==========================================
  Files         242      304      +62     
  Lines       23244    23397     +153     
==========================================
+ Hits         9263     9371     +108     
- Misses      13981    14026      +45     
Impacted Files Coverage Δ
boa_engine/src/vm/call_frame.rs 50.00% <0.00%> (-50.00%) ⬇️
...ine/src/syntax/ast/statement/iteration/for_loop.rs 38.09% <0.00%> (-7.81%) ⬇️
...e/src/syntax/ast/statement/iteration/while_loop.rs 40.00% <0.00%> (-5.00%) ⬇️
boa_engine/src/syntax/ast/statement/if.rs 53.84% <0.00%> (-4.49%) ⬇️
.../src/syntax/ast/statement/iteration/for_in_loop.rs 38.09% <0.00%> (-4.22%) ⬇️
.../src/syntax/ast/statement/iteration/for_of_loop.rs 39.13% <0.00%> (-3.73%) ⬇️
boa_engine/src/syntax/ast/statement/try/mod.rs 47.27% <0.00%> (-3.71%) ⬇️
boa_engine/src/syntax/ast/statement_list/mod.rs 62.50% <0.00%> (-3.58%) ⬇️
...a_engine/src/syntax/ast/function/arrow_function.rs 39.28% <0.00%> (-3.03%) ⬇️
...ne/src/syntax/parser/statement/labelled_stm/mod.rs 38.09% <0.00%> (-2.82%) ⬇️
... and 96 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jedel1043
Copy link
Member

Yeah, I think it would be better if people with a report could contact any member of our core team, just in case Jason is not available at that moment.

@RageKnify
Copy link
Contributor

Agree, I think we can all be relied upon to handle first contact for any problem.

@HalidOdat
Copy link
Member

Yes, agreed.

I will label as boa-dev/ryu-js#22 as blocked until this PR is merged :)

@Razican
Copy link
Member Author

Razican commented Oct 23, 2022

I have updated the contact method to the whole team. I think that everyone should approve it before merging. @jasonwilliams, @HalidOdat, @RageKnify, @raskad and @jedel1043

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 26, 2022
This updates the Code of Conduct to the Contributor Covenant v2.1 version (we were using the 2.0 version until now). Changes are very minor. As far as I can tell, the only content difference is the explicit mention of _caste_ and _color_ among the potential traits that could cause harassment.

Then it just changes the format a bit to make links a bit more user friendly, by not posting URLs directly.

But I have a question: should we update the contact method? It currently says the following:

> Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to the community leaders responsible for enforcement at [discord](https://discord.gg/tUFFk9Y) by contacting _JaseW_.

Maybe we should mention the `@boa-dev` group, and that they can contact anyone there. What do you think? I would also like to update this before boa-dev/ryu-js#22
@bors
Copy link

bors bot commented Oct 26, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Updated the Code of Conduct [Merged by Bors] - Updated the Code of Conduct Oct 26, 2022
@bors bors bot closed this Oct 26, 2022
@bors bors bot deleted the coc branch October 26, 2022 00:27
@Razican Razican added the hacktoberfest-accepted PR accepted for Hacktoberfest label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Issues needing more discussion hacktoberfest-accepted PR accepted for Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants