[Merged by Bors] - Removed some duplicate code, added ToIndentedString

[Razican]

In most cases, the ToInternedString was just calling self.to_indented_string(interner, 0). This avoids all this duplicate code by adding a new trait, ToIndentedString. Any type implementing that automatically implements ToInternedString.

I have also added a bunch of #[inline] in one-liners, and some one-line documentations for some functions.

I have noticed that we also use contains() and contains_arguments() a lot. Would it make sense to create traits for this?

[github-actions]

Test262 conformance changes

Test result	main count	PR count	difference
Total	93,383	93,383	0
Passed	69,114	69,114	0
Ignored	18,182	18,182	0
Failed	6,087	6,087	0
Panics	0	0	0
Conformance	74.01%	74.01%	0.00%

[codecov]

Codecov Report

Merging #2367 (b73b429) into main (80017fd) will decrease coverage by 0.04%.
The diff coverage is 73.78%.

@@            Coverage Diff             @@
##             main    #2367      +/-   ##
==========================================
- Coverage   39.88%   39.84%   -0.05%     
==========================================
  Files         243      243              
  Lines       23293    23318      +25     
==========================================
  Hits         9290     9290              
- Misses      14003    14028      +25     

Impacted Files	Coverage Δ
boa_engine/src/syntax/ast/expression/await.rs	8.33% <ø> (ø)
..._engine/src/syntax/ast/function/async_generator.rs	5.88% <0.00%> (ø)
boa_engine/src/syntax/ast/function/generator.rs	5.88% <0.00%> (ø)
boa_engine/src/syntax/ast/mod.rs	61.53% <ø> (ø)
boa_engine/src/syntax/ast/statement/labelled.rs	43.75% <ø> (ø)
boa_engine/src/syntax/ast/statement/switch/mod.rs	43.58% <28.57%> (-2.36%)	⬇️
...ne/src/syntax/ast/expression/literal/object/mod.rs	53.48% <33.33%> (+2.37%)	⬆️
boa_engine/src/syntax/ast/expression/mod.rs	39.39% <50.00%> (+1.15%)	⬆️
boa_interner/src/lib.rs	58.58% <50.00%> (+1.01%)	⬆️
boa_engine/src/syntax/ast/statement_list/mod.rs	62.50% <52.63%> (-2.96%)	⬇️
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[raskad]

Looks like a great change to me!

Concerning contains and contains_arguments, I think we should leave those as-is for now. I had the idea of maybe generating the results at parse time and writing them into the AST so that we do not have to walk the AST every time we call those functions. I did not look at it seriously, but If something like that works out, we could remove all of those functions.

[RageKnify]

LGTM, nothing to note

[Razican]

re-based :)

[raskad]

bors r+

[bors]

Pull request successfully merged into main.

Build succeeded:

• Clippy
• Documentation
• Examples
• Rustfmt
• Tests on Linux
• Tests on MacOS
• Tests on Windows