Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Allow LineTerminator before Semicolon in continue #2371

Closed
wants to merge 3 commits into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Oct 23, 2022

This Pull Request changes the following:

  • Check if there is a Semicolon after a LineTerminator is found in a continue statement.

@raskad raskad added bug Something isn't working parser Issues surrounding the parser labels Oct 23, 2022
@raskad raskad added this to the v0.17.0 milestone Oct 23, 2022
@github-actions
Copy link

github-actions bot commented Oct 23, 2022

Test262 conformance changes

Test result main count PR count difference
Total 93,383 93,383 0
Passed 69,114 69,116 +2
Ignored 18,182 18,182 0
Failed 6,087 6,085 -2
Panics 0 0 0
Conformance 74.01% 74.01% +0.00%
Fixed tests (2):
test/language/statements/continue/12.7-1.js [strict mode] (previously Failed)
test/language/statements/continue/12.7-1.js (previously Failed)

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Merging #2371 (ee7387b) into main (af5970e) will decrease coverage by 0.00%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main    #2371      +/-   ##
==========================================
- Coverage   40.05%   40.05%   -0.01%     
==========================================
  Files         304      304              
  Lines       23397    23400       +3     
==========================================
+ Hits         9371     9372       +1     
- Misses      14026    14028       +2     
Impacted Files Coverage Δ
...ne/src/syntax/parser/statement/continue_stm/mod.rs 65.00% <85.71%> (+6.17%) ⬆️
...ntax/parser/statement/iteration/while_statement.rs 52.63% <0.00%> (-5.27%) ⬇️
boa_engine/src/context/mod.rs 34.75% <0.00%> (-0.61%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Razican
Copy link
Member

Razican commented Oct 23, 2022

Looks good, but would it be possible to add a test for it? It seems it's not covered by Test262

@raskad
Copy link
Member Author

raskad commented Oct 23, 2022

Looks good, but would it be possible to add a test for it? It seems it's not covered by Test262

While fixing the failing test I accidentally re-wrote the bug from before :D
Now everything should be fine.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@HalidOdat
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 23, 2022
This Pull Request changes the following:

- Check if there is a Semicolon after a LineTerminator is found in a `continue` statement.
@bors
Copy link

bors bot commented Oct 23, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Allow LineTerminator before Semicolon in continue [Merged by Bors] - Allow LineTerminator before Semicolon in continue Oct 23, 2022
@bors bors bot closed this Oct 23, 2022
@bors bors bot deleted the fix-continue-line-terminator branch October 23, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants