Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Skip prototype field definition for arrow function #2388

Closed
wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Oct 26, 2022

This Pull Request changes the following:

  • Skip prototype field definition for arrow function
  • Add GetArrowFunction opcode

@raskad raskad added bug Something isn't working execution Issues or PRs related to code execution labels Oct 26, 2022
@raskad raskad added this to the v0.17.0 milestone Oct 26, 2022
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 93,789 93,789 0
Passed 69,181 69,185 +4
Ignored 18,352 18,352 0
Failed 6,256 6,252 -4
Panics 0 0 0
Conformance 73.76% 73.77% +0.00%
Fixed tests (4):
test/language/statements/class/subclass/superclass-arrow-function.js [strict mode] (previously Failed)
test/language/statements/class/subclass/superclass-arrow-function.js (previously Failed)
test/language/expressions/arrow-function/prototype-rules.js [strict mode] (previously Failed)
test/language/expressions/arrow-function/prototype-rules.js (previously Failed)

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #2388 (3aa8be2) into main (f026f20) will increase coverage by 0.04%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             main    #2388      +/-   ##
==========================================
+ Coverage   39.99%   40.04%   +0.04%     
==========================================
  Files         305      305              
  Lines       23327    23329       +2     
==========================================
+ Hits         9329     9341      +12     
+ Misses      13998    13988      -10     
Impacted Files Coverage Δ
boa_engine/src/builtins/function/mod.rs 22.27% <0.00%> (-0.28%) ⬇️
boa_engine/src/vm/opcode/mod.rs 50.00% <ø> (ø)
boa_engine/src/vm/opcode/get/function.rs 66.66% <87.50%> (+16.66%) ⬆️
boa_engine/src/bytecompiler/mod.rs 29.48% <100.00%> (+0.06%) ⬆️
boa_engine/src/vm/code_block.rs 32.73% <100.00%> (ø)
boa_engine/src/vm/mod.rs 57.14% <100.00%> (+0.14%) ⬆️
boa_engine/src/environments/compile.rs 43.83% <0.00%> (-1.37%) ⬇️
boa_engine/src/value/operations.rs 33.33% <0.00%> (+0.30%) ⬆️
boa_engine/src/error.rs 60.00% <0.00%> (+1.17%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Razican
Copy link
Member

Razican commented Oct 26, 2022

bors r+

bors bot pushed a commit that referenced this pull request Oct 26, 2022
This Pull Request changes the following:

- Skip prototype field definition for arrow function
- Add `GetArrowFunction` opcode
@bors
Copy link

bors bot commented Oct 26, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Skip prototype field definition for arrow function [Merged by Bors] - Skip prototype field definition for arrow function Oct 26, 2022
@bors bors bot closed this Oct 26, 2022
@bors bors bot deleted the arrow-function-creation-prototype-skip branch October 26, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants