Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Rewrite some patterns with let-else and ok_or_else #2404

Closed
wants to merge 2 commits into from

Conversation

jedel1043
Copy link
Member

This Pull Request updates the codebase to the newest version of rustc (1.65.0).

It changes the following:

@jedel1043 jedel1043 added the Internal Category for changelog label Nov 4, 2022
@jedel1043 jedel1043 added this to the v0.17.0 milestone Nov 4, 2022
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Test262 conformance changes

Test result main count PR count difference
Total 93,789 93,789 0
Passed 69,513 69,513 0
Ignored 18,352 18,352 0
Failed 5,924 5,924 0
Panics 0 0 0
Conformance 74.12% 74.12% 0.00%

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #2404 (d0c961c) into main (dc3b09a) will increase coverage by 0.04%.
The diff coverage is 44.00%.

@@            Coverage Diff             @@
##             main    #2404      +/-   ##
==========================================
+ Coverage   38.80%   38.85%   +0.04%     
==========================================
  Files         313      313              
  Lines       23897    23846      -51     
==========================================
- Hits         9274     9265       -9     
+ Misses      14623    14581      -42     
Impacted Files Coverage Δ
boa_ast/src/lib.rs 50.00% <ø> (ø)
boa_engine/src/builtins/array_buffer/mod.rs 9.02% <0.00%> (-0.47%) ⬇️
boa_engine/src/builtins/eval/mod.rs 10.81% <0.00%> (+0.28%) ⬆️
boa_engine/src/builtins/function/mod.rs 24.08% <0.00%> (+1.16%) ⬆️
.../src/builtins/iterable/async_from_sync_iterator.rs 16.66% <0.00%> (-0.48%) ⬇️
boa_engine/src/builtins/uri/mod.rs 9.70% <0.00%> (+0.09%) ⬆️
boa_engine/src/class.rs 0.00% <0.00%> (ø)
boa_engine/src/lib.rs 76.92% <ø> (ø)
boa_engine/src/object/internal_methods/proxy.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/opcode/iteration/for_await.rs 0.00% <0.00%> (ø)
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code clean-up! Thanks!

@Razican
Copy link
Member

Razican commented Nov 4, 2022

bors r+

bors bot pushed a commit that referenced this pull request Nov 4, 2022
This Pull Request updates the codebase to the newest version of rustc (1.65.0).

It changes the following:

- Bumps `rust-version` to 1.65.0.
- Rewrites some snippets to use the new let else, ok_or_else and some other utils.
- Removes the `rustdoc::missing_doc_code_examples` allow lint from our codebase. (Context: rust-lang/rust#101732)
@bors
Copy link

bors bot commented Nov 4, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Rewrite some patterns with let-else and ok_or_else [Merged by Bors] - Rewrite some patterns with let-else and ok_or_else Nov 4, 2022
@bors bors bot closed this Nov 4, 2022
@bors bors bot deleted the let-else branch November 4, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants